You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/01 22:21:20 UTC
[GitHub] [lucene] gsmiller opened a new issue, #11736: Promote DocValuesTermsQuery functionality from sandbox module
gsmiller opened a new issue, #11736:
URL: https://github.com/apache/lucene/issues/11736
### Description
Now that `TermInSetQuery` is able to estimate its cost and work with `IndexOrDocValuesQuery`, it would be nice to have a first-class doc-values-based term-in-set approach to pair with the current postings-based implementation. `DocValuesTermsQuery` in the sandbox module provides this, and I propose we promote the functionality out of `sandbox`.
One approach for this, brought up by @rmuir over in #11244, would be to refactor `TermInSetQuery` to extend `MultiTermQuery`. If we do that, we can provide a rewrite method that creates a doc-values-based approach, avoiding some duplicate code. The unknown right now is if extending `MultiTermQuery` would have any adverse performance side-effects on `TermInSetQuery` in general since the terms intersection is implemented a little differently. We would like to benchmark this before making the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller closed issue #11736: Promote DocValuesTermsQuery functionality from sandbox module
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed issue #11736: Promote DocValuesTermsQuery functionality from sandbox module
URL: https://github.com/apache/lucene/issues/11736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #11736: Promote DocValuesTermsQuery functionality from sandbox module
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on issue #11736:
URL: https://github.com/apache/lucene/issues/11736#issuecomment-1421239346
This was done as part of #12129. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #11736: Promote DocValuesTermsQuery functionality from sandbox module
Posted by GitBox <gi...@apache.org>.
gsmiller commented on issue #11736:
URL: https://github.com/apache/lucene/issues/11736#issuecomment-1234938538
Here's a draft PR showing how we might do this: #11739
If that approach ends up regressing "normal" term-in-set query behavior, we could take a simpler approach and just move the `DocValuesTermsQuery` out of sandbox I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #11736: Promote DocValuesTermsQuery functionality from sandbox module
Posted by GitBox <gi...@apache.org>.
gsmiller commented on issue #11736:
URL: https://github.com/apache/lucene/issues/11736#issuecomment-1234927353
I'll post a draft PR for this soon. I have the proposed changes on a local branch but just need to untangle it from some other work and rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org