You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Stephen Mallette (Jira)" <ji...@apache.org> on 2019/09/27 14:20:00 UTC

[jira] [Commented] (TINKERPOP-2247) Server should respect charset specified in request header

    [ https://issues.apache.org/jira/browse/TINKERPOP-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939489#comment-16939489 ] 

Stephen Mallette commented on TINKERPOP-2247:
---------------------------------------------

Since HTTP on Gremlin Server basically only supports JSON which (i think) must encode to UTF-8, is there any reason to make this dynamically determined? 

As a side note, personally speaking, i'm generally +0 on expanding the HTTP features/complexity as we don't really promote that feature. The preference for this sort of thing is definitely GLVs and/or possibly script based driver interaction.

> Server should respect charset specified in request header
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-2247
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2247
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.3.7
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> Currently, the server uses UTF-8 as its default charset and that is hardcoded in the system [1], irrespective of the content-type provided in the request. This task is to read the charset from the HTTP Content-Type header and use the charset to encode the response string.
>  [1][https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java#L254]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)