You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Weston Pace (Jira)" <ji...@apache.org> on 2022/03/22 03:41:00 UTC
[jira] [Resolved] (ARROW-14960) [C++] Add exception to Arrow style guide based on changes in Google style guide that we are not adopting
[ https://issues.apache.org/jira/browse/ARROW-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston Pace resolved ARROW-14960.
---------------------------------
Fix Version/s: 8.0.0
Resolution: Fixed
Issue resolved by pull request 12661
[https://github.com/apache/arrow/pull/12661]
> [C++] Add exception to Arrow style guide based on changes in Google style guide that we are not adopting
> --------------------------------------------------------------------------------------------------------
>
> Key: ARROW-14960
> URL: https://issues.apache.org/jira/browse/ARROW-14960
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Ben Kietzman
> Assignee: Weston Pace
> Priority: Minor
> Labels: pull-request-available
> Fix For: 8.0.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> As of https://github.com/google/styleguide/commit/7a7a2f510efe7d7fc5ea8fbed549ddb31fac8f3e the Google Style Guide no longer forbids use of mutable references for output arguments, and actually encourages using them when the output argument is not optional.
> This puts arrow c++ style out of sync since we've continued to police toward usage of pointers for output arguments. We could:
> - keep the ban and note this as a deviation from google style in [development.rst|https://github.com/bkietz/arrow/blob/392af8aa999f940ab8fd61684820b2c6d89f7871/docs/source/developers/cpp/development.rst#L74-L75]
> - open JIRA(s) for deprecating/replacing pointer-output APIs where applicable
--
This message was sent by Atlassian Jira
(v8.20.1#820001)