You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/11/26 17:58:28 UTC
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/585
Footer & Queryoptions update
three commits:
```
footer: text update
```
```
remove update seq
update_seq does not work with couchdb 2. the footer text also was
not visible because of a css issue for months.
```
```
remove broken showStale
this was broken in multiple ways (option not visible and if option
visible changing it made no effect)
remove the feature as it has 0 users.
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton footer-update-update-seq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #585
----
commit 5ce69dfa142a295abe8fc9ef0a1aa8588b5aaa3c
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-26T14:41:13Z
footer: text update
commit f8449c9422b4636d0c8fc1e8dfa136d020f6a05b
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-26T16:45:15Z
remove update seq
update_seq does not work with couchdb 2. the footer text also was
not visible because of a css issue for months.
commit e957c01f4ae8a6f0dc1a9ca8bfb2bf70e96a1db4
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-26T16:53:10Z
remove broken showStale
this was broken in multiple ways (option not visible and if option
visible changing it made no effect)
remove the feature as it has 0 users.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/585#discussion_r46002709
--- Diff: app/addons/documents/queryoptions/actiontypes.js ---
@@ -17,7 +17,6 @@ define([], function () {
QUERY_TOGGLE_BETWEEN_KEYS: 'QUERY_TOGGLE_BETWEEN_KEYS',
QUERY_UPDATE_BETWEEN_KEYS: 'QUERY_UPDATE_BETWEEN_KEYS',
QUERY_UPDATE_BY_KEYS: 'QUERY_UPDATE_BY_KEYS',
- QUERY_TOGGLE_UPDATE_SEQ: 'QUERY_TOGGLE_UPDATE_SEQ',
QUERY_TOGGLE_DESCENDING: 'QUERY_TOGGLE_DESCENDING',
QUERY_TOGGLE_REDUCE: 'QUERY_TOGGLE_REDUCE',
QUERY_UPDATE_SKIP: 'QUERY_UPDATE_SKIP',
--- End diff --
I think we can remove QUERY_SHOW_STALE from this file too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/585#issuecomment-159979945
Other than the minor things above, code looks good + works fine. I'm all for removing features that are simply not used. I wonder if people will notice that the stale option is no longer there and pipe up.
But I think +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/585#discussion_r46002668
--- Diff: app/addons/documents/pagination/pagination.react.jsx ---
@@ -139,16 +138,10 @@ define([
pageNumber: function () {
if (this.state.totalRows === 0) {
- return <p> Showing 0 documents. </p>;
+ return <p>Showing 0 documents.</p>;
--- End diff --
Maybe drop the period?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Footer & Queryoptions update
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/585#issuecomment-160158599
fixed and merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---