You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ChickenMythic <gi...@git.apache.org> on 2016/03/15 10:31:17 UTC
[GitHub] cordova-weinre pull request: Update HookLib.coffee
GitHub user ChickenMythic opened a pull request:
https://github.com/apache/cordova-weinre/pull/14
Update HookLib.coffee
Support IE Mobile (Windows Phone 8.1+)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChickenMythic/cordova-weinre master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-weinre/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit f99697e489c4c47bcb0e74f602a1f64f95d0a675
Author: ChickenMythic <dt...@outlook.com>
Date: 2016-03-15T09:30:34Z
Update HookLib.coffee
Support IE Mobile (Windows Phone 8.1+)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-weinre pull request: Support IE Mobile
Posted by pmuellr <gi...@git.apache.org>.
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197296847
I've opened https://issues.apache.org/jira/browse/CB-10886
Also, just wanted to let you know there are better tools than weinre available now. Info here, but honestly not sure what the state of debug on Windows phones is currently:
http://people.apache.org/~pmuellr/weinre/docs/latest/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-weinre pull request: Support IE Mobile
Posted by ChickenMythic <gi...@git.apache.org>.
Github user ChickenMythic commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197206256
There is no issue opened for this at Jira, you create one if you want to, I won't do it.
Here is the issue description:
We've used weinre library and the code is executed in webview on various mobile platforms (iOS, Android and WindowsPhone). It works fine on iOS and Android but not on WindowsPhone as IE (11) does not support overriding of standard storage functions.
All values set as storage properties are cast to String. As a result, localStorage getItem, setItem and removeItem functions are no more functions and thus, we can no longer use localStorage once weinre got initialized.
By digging into our code, it led us to weinre library code, then we found it came from this line un "_weinre.web/modules/weinre/common/HookLib.coffee_".
The test originally made to avoid this issue on IE was made for the Desktop version of IE but did not take the Mobile version into account that's why I just suggested to add "IEMobile" to this condition.
WindowsPhone uses a slightly different version of IE 11.
Let me know if you think this fix is appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-weinre pull request: Support IE Mobile
Posted by ChickenMythic <gi...@git.apache.org>.
Github user ChickenMythic commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197308612
Thank you.
You're right for WindowsPhone (for example), Visual Studio is well suited to debuggued webviews but it actually requires to use Visual Studio itself. Our web dev work on Unix machines and use Weinre for remote debugging. This way they can debug the same webview piece of code executed on different webview from different mobile platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-weinre pull request: Support IE Mobile
Posted by pmuellr <gi...@git.apache.org>.
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197292090
@sgrebnov I believe you added this bit of code way back when; anything else we need to look out for here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-weinre pull request: Support IE Mobile
Posted by pmuellr <gi...@git.apache.org>.
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197084191
Is there an issue open for this at Jira? You can open one [here](https://issues.apache.org/jira/secure/CreateIssueDetails!init.jspa?pid=12312420&components=12316604&priority=3&issuetype=1), or I can create one.
The issue - or description of the issue here that I will create - should provide some information about why this is needed. Eg, which browser version, library, etc does this new user agent show up in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org