You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/17 15:34:39 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #878: IGNITE-17148 Support for abstract configuration

tkalkirill commented on code in PR #878:
URL: https://github.com/apache/ignite-3/pull/878#discussion_r900263788


##########
modules/configuration-annotation-processor/src/integrationTest/java/org/apache/ignite/internal/configuration/processor/ItConfigurationProcessorTest.java:
##########
@@ -427,11 +432,186 @@ void testSuccessInternalIdFieldCodeGeneration() {
         assertTrue(batchCompile.getBySchema(cls).allGenerated());
     }
 
+    @Test
+    void testFailValidationForAbstractConfiguration() {
+        String packageName = "org.apache.ignite.internal.configuration.processor.abstractconfig.validation";
+
+        // Let's check the incompatible configuration schema annotations.

Review Comment:
   I think that it is not necessary, or you insist?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org