You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/05/21 07:21:58 UTC
[shardingsphere] branch master updated: Fix sonar issues on Rename this method name to match the regular expression: '^assert[A-Z][a-zA-Z0-9]*$' (#25818)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new e9a5d6eaaa4 Fix sonar issues on Rename this method name to match the regular expression: '^assert[A-Z][a-zA-Z0-9]*$' (#25818)
e9a5d6eaaa4 is described below
commit e9a5d6eaaa45f7a37cef959a5f052d3c1026bd99
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun May 21 15:21:51 2023 +0800
Fix sonar issues on Rename this method name to match the regular expression: '^assert[A-Z][a-zA-Z0-9]*$' (#25818)
---
.../select/projection/engine/ProjectionsContextEngineTest.java | 10 +++++-----
.../core/resultset/GeneratedKeysResultSetMetaDataTest.java | 2 +-
.../unsupported/UnsupportedGeneratedKeysResultSetTest.java | 8 ++++----
.../jdbc/unsupported/UnsupportedOperationResultSetTest.java | 4 ++--
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/infra/binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionsContextEngineTest.java b/infra/binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionsContextEngineTest.java
index 6a6af1d5ad2..96a3ad94624 100644
--- a/infra/binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionsContextEngineTest.java
+++ b/infra/binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionsContextEngineTest.java
@@ -147,27 +147,27 @@ class ProjectionsContextEngineTest {
}
@Test
- void createProjectionsContextWhenOrderByContextOrderItemsPresentForMySQL() {
+ void assertCreateProjectionsContextWhenOrderByContextOrderItemsPresentForMySQL() {
createProjectionsContextWhenOrderByContextOrderItemsPresent(new MySQLSelectStatement());
}
@Test
- void createProjectionsContextWhenOrderByContextOrderItemsPresentForOracle() {
+ void assertCreateProjectionsContextWhenOrderByContextOrderItemsPresentForOracle() {
createProjectionsContextWhenOrderByContextOrderItemsPresent(new OracleSelectStatement());
}
@Test
- void createProjectionsContextWhenOrderByContextOrderItemsPresentForPostgreSQL() {
+ void assertCreateProjectionsContextWhenOrderByContextOrderItemsPresentForPostgreSQL() {
createProjectionsContextWhenOrderByContextOrderItemsPresent(new PostgreSQLSelectStatement());
}
@Test
- void createProjectionsContextWhenOrderByContextOrderItemsPresentForSQL92() {
+ void assertCreateProjectionsContextWhenOrderByContextOrderItemsPresentForSQL92() {
createProjectionsContextWhenOrderByContextOrderItemsPresent(new SQL92SelectStatement());
}
@Test
- void createProjectionsContextWhenOrderByContextOrderItemsPresentForSQLServer() {
+ void assertCreateProjectionsContextWhenOrderByContextOrderItemsPresentForSQLServer() {
createProjectionsContextWhenOrderByContextOrderItemsPresent(new SQLServerSelectStatement());
}
diff --git a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/resultset/GeneratedKeysResultSetMetaDataTest.java b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/resultset/GeneratedKeysResultSetMetaDataTest.java
index beef0d22c29..9efd361fa92 100644
--- a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/resultset/GeneratedKeysResultSetMetaDataTest.java
+++ b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/resultset/GeneratedKeysResultSetMetaDataTest.java
@@ -94,7 +94,7 @@ class GeneratedKeysResultSetMetaDataTest {
}
@Test
- void getSchemaName() throws SQLException {
+ void assertGetSchemaName() throws SQLException {
assertThat(actualMetaData.getSchemaName(1), is(""));
}
diff --git a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedGeneratedKeysResultSetTest.java b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedGeneratedKeysResultSetTest.java
index a79163e27b5..8039b41dce5 100644
--- a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedGeneratedKeysResultSetTest.java
+++ b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedGeneratedKeysResultSetTest.java
@@ -88,17 +88,17 @@ class UnsupportedGeneratedKeysResultSetTest {
}
@Test
- void getTimeWithColumnLabelAndCalendar() {
+ void assertGetTimeWithColumnLabelAndCalendar() {
assertThrows(SQLFeatureNotSupportedException.class, () -> actual.getTime("", null));
}
@Test
- void getTimestampWithColumnIndex() {
+ void assertGetTimestampWithColumnIndex() {
assertThrows(SQLFeatureNotSupportedException.class, () -> actual.getTimestamp(1));
}
@Test
- void getTimestampWithColumnIndexAndCalendar() {
+ void assertGetTimestampWithColumnIndexAndCalendar() {
assertThrows(SQLFeatureNotSupportedException.class, () -> actual.getTimestamp(1, null));
}
@@ -208,7 +208,7 @@ class UnsupportedGeneratedKeysResultSetTest {
}
@Test
- void getFetchDirection() {
+ void assertGetFetchDirection() {
assertThrows(SQLFeatureNotSupportedException.class, () -> actual.getFetchDirection());
}
diff --git a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationResultSetTest.java b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationResultSetTest.java
index a6162b2f7df..3fd33e0d9e8 100644
--- a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationResultSetTest.java
+++ b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationResultSetTest.java
@@ -174,12 +174,12 @@ class UnsupportedOperationResultSetTest {
}
@Test
- void getNCharacterStreamForColumnIndex() {
+ void assertGetNCharacterStreamForColumnIndex() {
assertThrows(SQLFeatureNotSupportedException.class, () -> shardingSphereResultSet.getNCharacterStream(1));
}
@Test
- void getNCharacterStreamForColumnLabel() {
+ void assertGetNCharacterStreamForColumnLabel() {
assertThrows(SQLFeatureNotSupportedException.class, () -> shardingSphereResultSet.getNCharacterStream("label"));
}