Posted by "Victor Dolirio F. Barbosa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893336#action_12893336 ]
Victor Dolirio F. Barbosa commented on WICKET-2620:
---------------------------------------------------
I have exactly the same problem. I've a specialized class for DataTable and in the tag resolving phase, wicket claims that there is no closing tag for <thead wicket:id="topToolbars">. My HTML is as follows:
<wicket:panel>
<thead wicket:id="topToolbars">
<wicket:container wicket:id="toolbar"></wicket:container>
</thead>
<tfoot wicket:id="bottomToolbars">
<wicket:container wicket:id="toolbar"></wicket:container>
</tfoot>
<tbody>
<tr wicket:id="rows">
<td wicket:id="cells">
<span wicket:id="cell">[cell]</span>
</td>
</tr>
</tbody>
</wicket:panel>
Thnx for any regard.
> DataTable generates two <thead wicket:id="topToolbars">
> -------------------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.6, 1.5-M1
>
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2620) CLONE -DataTable does not generate
"thead" tag
Posted by "Stefan Schueffler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790823#action_12790823 ]
Stefan Schueffler commented on WICKET-2620:
-------------------------------------------
Hi
this is just to ensure that the issue is still open (and therefore not resolved), as i have no permission to reopen closed issues.
The DataTable-component erroneously emits as many thead and tfoot sections as there are top- and footer-toolbars added to the table.
Although there might be many tbody-elements, the thead and tfoot is only allowed at most one time per table.
The supplied patch in the original issue seems to resolve this, as my own patch looks exactly the same.
Regards
Stefan
> CLONE -DataTable does not generate "thead" tag
> ----------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.4, 1.5-M1
>
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2620) DataTable generates two
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2620.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.6
Assignee: Juergen Donnerstag (was: Igor Vaynberg)
fixed and added test case
> DataTable generates two <thead wicket:id="topToolbars">
> -------------------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.6, 1.5-M1
>
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2620) DataTable generates two
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2620:
----------------------------------
Summary: DataTable generates two <thead wicket:id="topToolbars"> (was: CLONE -DataTable does not generate "thead" tag)
> DataTable generates two <thead wicket:id="topToolbars">
> -------------------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Igor Vaynberg
> Priority: Minor
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2620) DataTable generates two
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861020#action_12861020 ]
James Carman commented on WICKET-2620:
--------------------------------------
I believe the fix for this issue has caused a regression in my code. I have a custom subclass of DataTable with markup:
<wicket:panel>
<span wicket:id="topToolbars">
<span wicket:id="toolbar"></span>
</span>
<tr wicket:id="rows">
<td wicket:id="cells">
<span wicket:id="cell">[cell]</span>
</td>
</tr>
<span wicket:id="bottomToolbars">
<span wicket:id="toolbar"></span>
</span>
</wicket:panel>
In 1.4.6, my page fails to render. In 1.4.5, it works fine.
> DataTable generates two <thead wicket:id="topToolbars">
> -------------------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.6, 1.5-M1
>
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2620) CLONE -DataTable does not generate
"thead" tag
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2620:
----------------------------------
Fix Version/s: (was: 1.4.4)
(was: 1.5-M1)
> CLONE -DataTable does not generate "thead" tag
> ----------------------------------------------
>
> Key: WICKET-2620
> URL: https://issues.apache.org/jira/browse/WICKET-2620
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.3
> Reporter: Stefan Schueffler
> Assignee: Igor Vaynberg
> Priority: Minor
>
> The tables generated by DataTable component in the current version of Wicket (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
> <tr class="navigation">
> {html}
> When you look at http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
> <tr class="navigation">
> {html}
> Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.