You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by jm...@apache.org on 2024/02/08 04:14:37 UTC
(datasketches-python) 01/08: Fix to generate proper Apple Silicon wheels, bump versions to mitigate GH warnings
This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a commit to branch 5.0.x-patch
in repository https://gitbox.apache.org/repos/asf/datasketches-python.git
commit 6b1c38deac56c8fa87f2d24174f978a78fb64734
Author: Jon Malkin <78...@users.noreply.github.com>
AuthorDate: Wed Feb 7 17:47:34 2024 -0800
Fix to generate proper Apple Silicon wheels, bump versions to mitigate GH warnings
---
.github/workflows/build_wheels.yml | 10 +++++++---
pyproject.toml | 3 ---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
index a668a67..54d139f 100644
--- a/.github/workflows/build_wheels.yml
+++ b/.github/workflows/build_wheels.yml
@@ -69,10 +69,10 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
- name: Set up Python 3.x
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: '3.x'
@@ -88,8 +88,12 @@ jobs:
- name: Build wheels
run: python -m cibuildwheel --output-dir dist
env:
+ CIBW_ENVIRONMENT_MACOS: CMAKE_OSX_ARCHITECTURES=${{ matrix.config.cibw-arch == 'macosx_x86_64' && 'x86_64' || matrix.config.cibw-arch == 'macosx_arm64' && 'arm64' || '' }}
CIBW_BUILD: "*-${{ matrix.config.cibw-arch }}"
+ MACOSX_DEPLOYMENT_TARGET: "10.14" # min supporting c++17
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
with:
+ name: pypi_wheels
path: ./dist/*.whl
+ compression-level: 0 # contents are already compressed
diff --git a/pyproject.toml b/pyproject.toml
index ff2becd..5c584ec 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -36,6 +36,3 @@ before-build = "yum remove -y cmake"
[tool.cibuildwheel.macos]
archs = ["x86_64", "arm64"]
-
-# Minimum version for proper C++17 support on MacOS
-environment = { MACOSX_DEPLOYMENT_TARGET = "10.14" }
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org