You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/05/07 23:04:20 UTC
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/19
Support getting arguments from URL or file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-client support-url-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-client/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 0a0ea6701d38bb91c14906a3147ad0754b938721
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-05-02T21:13:01Z
Support getting arguments from URL or file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/19#issuecomment-221061653
Oh that sort of thing - yes it would be good to introduce more of that too. Could start gradually building up tests for each command, starting with the most used ones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/19#issuecomment-221049221
This all looks very sensible to me.
Is it time to start writing automated tests, though?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-client/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/19#issuecomment-221057396
A fair point. I will try to make some time to extend https://github.com/apache/brooklyn-client/blob/master/test/test.sh and then we can find somewhere to run it regularly,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Support getting arguments from URL o...
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/19#issuecomment-221061284
I wonder if we would be better to start introducing tests that are [idomatic to golang](https://golang.org/pkg/testing/)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---