You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2023/06/12 09:37:30 UTC
[GitHub] [doris] englefly opened a new pull request, #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
englefly opened a new pull request, #20713:
URL: https://github.com/apache/doris/pull/20713
## Proposed changes
good for ds15/44
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1594422983
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1594423687
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on a diff in pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on code in PR #20713:
URL: https://github.com/apache/doris/pull/20713#discussion_r1231827382
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -252,10 +271,19 @@ public Cost visitPhysicalHashJoin(
leftRowCount + rightRowCount,
penalty);
}
+
+ if (context.isBroadcastJoin()) {
+ double broadcastJoinPenalty = broadCastJoinBalancePenalty(probeStats, buildStats);
+ return CostV1.of(leftRowCount * broadcastJoinPenalty + rightRowCount + outputRowCount,
Review Comment:
I think we would better to set up cost system on more dimension, for distinguishing the bc and shuffle, for example, we would consider exchange data cost, parallelism info to compare these two, by simulating the real execution difference between bc and shuffle as close as possible. In comparison, the introduced penalty parameter is meaningless, such as BROADCAST_JOIN_SKEW_RATIO, and will easily to be broken under different scenario in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1592201010
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1593814700
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #20713:
URL: https://github.com/apache/doris/pull/20713#discussion_r1231984958
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -252,10 +271,19 @@ public Cost visitPhysicalHashJoin(
leftRowCount + rightRowCount,
penalty);
}
+
+ if (context.isBroadcastJoin()) {
+ double broadcastJoinPenalty = broadCastJoinBalancePenalty(probeStats, buildStats);
+ return CostV1.of(leftRowCount * broadcastJoinPenalty + rightRowCount + outputRowCount,
Review Comment:
this idea can be implemented in CostModelV2. In V1, we do not have this dimension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1592848563
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1594514262
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #20713: [opt](nereids) adjust cost model for BroadCastJoin and PartitionJoin
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #20713:
URL: https://github.com/apache/doris/pull/20713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20713:
URL: https://github.com/apache/doris/pull/20713#issuecomment-1594006765
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org