You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2003/08/04 15:50:05 UTC
Recommending attached instead of inline patches?
Daniel Stenberg <da...@haxx.se> writes:
> Personally, I think using attachments for patches is the better way. Both for
> people and for mail archivers. (Yes, I know the policy here express a
> different opinion.)
>
> If attachments were used, they would also be easier to find and
> manage in this intense mail traffic thanks to hypermail's
> "attachment index" (like this
> http://www.contactor.se/~dast/svn/archive-2003-08/attachment.shtml).
I'm beginning to think we should just change that policy. It's
slightly more convenient to review an inline patch -- but not by much.
And sometimes people's mailers munge them, and mail archivers don't
behave as well, etc. The costs may outweigh the benefit...
Most mailreaders have a way to expand the attachment. (Note to fellow
GNUS users: it's the 'K' prefix in the summary buffer, type "K C-h" to
see the possibilities. For example: "C-u 2 K i" views the MIME
attachment numbered '2' inline.)
Would anyone object to this? I'd be happy to provide GNUS support for
those who need it during the transition :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Recommending attached instead of inline patches?
Posted by kf...@collab.net.
Okay, so far, two people who review patches have said -0, so I'm not
going to push this suggestion. Thanks for the feedback :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Recommending attached instead of inline patches?
Posted by Sander Striker <st...@apache.org>.
> From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
> Sent: Monday, August 04, 2003 11:19 PM
> --On Monday, August 04, 2003 10:50:05 -0500 kfogel@collab.net wrote:
>> I'm beginning to think we should just change that policy. It's
>> slightly more convenient to review an inline patch -- but not by much.
>> And sometimes people's mailers munge them, and mail archivers don't
>> behave as well, etc. The costs may outweigh the benefit...
In this case, the benefit is almost close to nil.
> -0. I don't trust mailers to get this right, and we don't need more
> obstacles to reviewing patches that are sent in. I don't give a fig about
> archivers if it means that it's impossible to review the attachments for
> people reading the list currently.
Not to mention that there will be less review, simply because you don't
see the patch straight away.
> IIRC, at one point Sander tried attaching patches (if not here, then to
> dev@httpd), but LookOut! always munged them so that no one else could ever
> view them.
Nope, the other way around. I was having trouble sending inline patches
since you have to set your max line width globally (and it only goes to
132). Once I set that inline patches were doable.
> I think it was eventually resolved that it was impossible for
> Outlook to do this right with attachments at all. Considering how many
> people use Outlook, asking for attachments by default is going to be a mess
> that I don't want a part of. -- justin
It's going to be more hassle to view them, which is a shame. With broken
mail clients, like the one I use, viewing something with an extension other
than .patch or .txt (the latter giving trouble with unix line endings, since
it defaults to notepad), is an utter pain. You have to save the patch to
disk first, before you can open it in that case.
So, a strong -0 on going to attached patches.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Recommending attached instead of inline patches?
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Monday, August 04, 2003 10:50:05 -0500 kfogel@collab.net wrote:
> I'm beginning to think we should just change that policy. It's
> slightly more convenient to review an inline patch -- but not by much.
> And sometimes people's mailers munge them, and mail archivers don't
> behave as well, etc. The costs may outweigh the benefit...
-0. I don't trust mailers to get this right, and we don't need more
obstacles to reviewing patches that are sent in. I don't give a fig about
archivers if it means that it's impossible to review the attachments for
people reading the list currently.
IIRC, at one point Sander tried attaching patches (if not here, then to
dev@httpd), but LookOut! always munged them so that no one else could ever
view them. I think it was eventually resolved that it was impossible for
Outlook to do this right with attachments at all. Considering how many
people use Outlook, asking for attachments by default is going to be a mess
that I don't want a part of. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Recommending attached instead of inline patches?
Posted by Daniel Stenberg <da...@haxx.se>.
On Mon, 4 Aug 2003 kfogel@collab.net wrote:
> I'm beginning to think we should just change that policy. It's slightly
> more convenient to review an inline patch -- but not by much. And sometimes
> people's mailers munge them, and mail archivers don't behave as well, etc.
> The costs may outweigh the benefit...
As I've already said, I am +1 on this.
Most mail programs these days should be able to view attachments, and if
anyone uses a mailer that doesn't I think it is about time to upgrade to one.
I find it a lot easier to deal with patches sent as attachments, as mailers
tend to word wrap and otherwise ruin "inline" texts but they do not tend to do
that as frequently in attachments.
--
Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org