You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/28 08:16:29 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4111: [WIP] API-call to declare host as dead
GabrielBrascher opened a new pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111
## Description
<!--- Describe your changes in detail -->
Sometimes it can happen that a host is dead (admins know) but CS is uncertain and VMs stay in the 'Running' state.
CloudStack will not perform HA at this moment because it can't be sure the VMs are dead. With that in mind, this PR proposes an API-call (and UI button) where you can manually declare a Host as dead. All VMs 'Running' on that Host should then be set to 'Stopped' so HA can kick in.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-892815730
@RodrigoDLopez @rhtyd this one would still be relevant for some scenarios.
It is proposed as an alternative when clusters have no HA enabled or the HA is not detecting a host as problematic but ADMINS are aware of the situation and then decide to use this API command to manually "fence" the host.
Thanks for the review/testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#discussion_r618569433
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/host/CancelHostAsDegradedCmd.java
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.host;
+
+import com.cloud.event.EventTypes;
+import com.cloud.host.Host;
+import com.cloud.utils.fsm.NoTransitionException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = "cancelHostAsDegraded",
+ description = "Cancel host status from 'Degraded'. Host will transit back to status 'Enabled'.",
+ since = "4.15.0.0",
Review comment:
Thanks for the review @ravening, you are right. I will update it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-825689005
@ravening thanks for your time. Code has been updated fitting your review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894053492
double check :(
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665742105
Suggestions:
- Unavailable
- Degraded
- Offline
- Defect
- Inactive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-658968205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650628587
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-709535847
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725454077
Me _pinging_ for review again :-)
@rhtyd, @nvazquez, @andrijapanicsb, @borisstoyanov, @svenvogel, @weizhouapache, @RodrigoDLopez, @svenvogel, @kiwiflyer, @wido and others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-646838607
Hello Gabriel, nice feature.
I did some manual testing, and it seems to me that everything is correct.
**Environment**
- 2 Hosts KVM with HA enable
- H01
- H02
- Local and shared storage
**Test 01**
- Try to declare an enable host as dead
**Expected:** Do nothing, and inform this on response
**Result:** as expected the API responds "Cannot perform declare host [id=1, name=kvm413] as 'Dead' when host is in Up status"
**Test 02**
- Try to cancel host declared as dead on an enable host
**Expected:** Do nothing, and infor this on response
**Result:** as expected the API responds "Failed to Cancel host from Dead status due to: Cannot perform cancelHostAsDead on host [id=1, name=kvm413] when host is in Enabled state"
**Test 03**
- migrate VR to H01
- deploy 1 vm with HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate VR and instance to a suitable host.
**Result:** all good, as expected
**Test 04**
- deploy 2 vms with HA enable on H01
- deploy 1 vms without HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Vms with HA enable migrate to a suitable host, vm without HA enable stay in stopped state
**Result:** as expected, vms with HA enable was placed at a suitable host, vms without HA enable, need to be wake up manualy
**Test 05**
- migrate ssvm, cpvm and vr to H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate ssvm, cpvm and vr to a suitable host
Result: As expected those instances was migrated to a suitable host.
**Test 06**
- disable HA on H01 and H02
- deploy 2 vms with HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** I dont know what is the expected behavior here.
**Result:** Migrate those instances to a suitable host
**Test 07**
- disable HA on H01 and H02
- migrate ssvm, cpvm, vr to H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate those instances to a suitable host.
**Result:** Migrate those instances to a suitable host
LGTM based on this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665738632
@DaanHoogland your observation makes sense, I will look for a better word ;)
Thanks for the input!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712794063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678490301
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-667085891
@wido that is a nice set of options, thanks!
I am looking for a generic term of telling that the Host needs some attention from Admins (when problems could be either application, network, hardware, etc). It also must be totally different from current options for host/agent status (e.g. _Down_, _Disconnected_, and _Alert_).
With that in mind, _Offline_ or _Unavailable_ might bring confusion regarding the existing _Disconnect_ and _Down_ states. On the other way, _Defect_ seems a good option; I also like _Problematic_.
A nice option would also be [Degraded](https://github.com/apache/cloudstack/blob/36ef85012f69af59657c87ad88184769549d8792/api/src/main/java/org/apache/cloudstack/ha/HAConfig.java#L69), it already is used by [HAConfig.java](https://github.com/apache/cloudstack/blob/36ef85012f69af59657c87ad88184769549d8792/api/src/main/java/org/apache/cloudstack/ha/HAConfig.java) to say that a Host needs to be fenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650632802
Packaging result: ✔centos7 ✔debian. JID-1475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-892815730
@RodrigoDLopez @rhtyd this one would still be relevant for some scenarios.
It is proposed as an alternative when clusters have no HA enabled or the HA is not detecting a host as problematic but ADMINS are aware of the situation and manually "fence" the host.
Thanks for the review/testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893218210
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712793763
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724511
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669581733
Packaging result: ✔centos7 ✔debian. JID-1665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694875978
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712793763
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-709536480
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650628399
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678638664
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893210471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-892815730
@RodrigoDLopez @rhtyd this one would still be relevant for some scenarios.
It is proposed as an alternative when clusters have no HA enabled or the HA is not detecting a host as problematic but ADMINS are aware of the situation and manually "fence" the host.
Thanks for the review/testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-878193592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-709535847
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-724969476
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669550530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712776679
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650628587
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849092100
I'm commenting because I was asked...
If you look at the state diagram [1], I think you need to move to 'degraded' and expect the CloudStack to reboot the host using OOBM **or** jump to 'fencing' where CloudStack shuts the host down and restarts the VMs elsewhere.
I think bypassing the current logic by having 'degraded' immediately restart VMs, will make an already complicated process completely unfathomable.
[1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Host+HA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849180646
@PaulAngus just to be clear, I am not touching on the `HAState`, but instead on the `ResourceState`. And this has specific reasons that I hope will be clarified with this answer.
I am sorry for any confusion that might be due to the naming that was chosen; I can change the whole context from declaring host as `Degraded` to other options, such as `Problematic`, or any other word (initially it was `Dead`, but it was changed to a better word).
With that said, I totally agree with you when you say that this implementation adds complexity to an already convoluted execution flow. But out of all the options I imagine it to be one of the best options.
I created `ResourceState.Degraded` to keep the current HA state machine as it is, avoiding higher complexity and eventual issues. On top of that, the proposed state `ResourceState.Degraded` creates a unique case, where instead of the CloudStack HA defining a problematic host, the Admin places the Host as _Degraded_. This is something that helps on tracking what is happening and also to get back the host from the `ResourceState.Degraded` state to `ResourceState.Enabled`, or `ResourceState.Maintenance`.
Additionally, your idea of "forcing" transiting the `HAState` to a state that would lead to either `Fencing` or `Recovering` the host is quite interesting but has a few issues.
1. the `HAState.Degraded` state does not allow transiting to `HAState.Recovering` neither to `HAState.Fencing`. Here is how the `HAState.Degraded` state transition table works:
```
+----------+---------------------------------------+------------+
| State | Event | Next State |
+----------+---------------------------------------+------------+
| Degraded | Event.Disabled | Disabled |
+----------+---------------------------------------+------------+
| Degraded | Event.Ineligible | Ineligible |
+----------+---------------------------------------+------------+
| Degraded | Event.HealthCheckFailed | Degraded |
+----------+---------------------------------------+------------+
| Degraded | Event.HealthCheckPassed | Available |
+----------+---------------------------------------+------------+
| Degraded | Event.PeriodicRecheckResourceActivity | Suspect |
+----------+---------------------------------------+------------+
```
2. the HA state machine allows transiting to `HAState.Recovering` via `HAState.Checking`, when a threshold of failures is reached; which is not feasible to do in the specific situation that this PR has been designed to handle
```
+----------+------------------------------------------------+------------+
| State | Event | Next State |
+----------+------------------------------------------------+------------+
| Checking | Event.Disabled | Disabled |
+----------+------------------------------------------------+------------+
| Checking | Event.Ineligible | Ineligible |
+----------+------------------------------------------------+------------+
| Checking | Event.TooFewActivityCheckSamples | Suspect |
+----------+------------------------------------------------+------------+
| Checking | Event.ActivityCheckFailureUnderThresholdRatio | Degraded |
+----------+------------------------------------------------+------------+
| Checking | Event.ActivityCheckFailureOverThresholdRatio | Recovering |
+----------+------------------------------------------------+------------+.
```
3. the HA State machine was designed with the only purpose of being an automated system in which the transitions are all based on failure checks; therefore, adding a manual operation is quite hard and might do more harm than good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893218557
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-724973392
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-647619058
Thanks for testing and reviewing, @RodrigoDLopez!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712794063
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694810121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-820566815
ping for review: @DaanHoogland @andrijapanicsb @PaulAngus @svenvogel @RodrigoDLopez @GutoVeronezi @weizhouapache @ravening & others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669550530
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694875273
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-724928547
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694809757
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-710111854
<b>Trillian test result (tid-2974)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 70470 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4111-t2974-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_deploy_and_upgrade_kubernetes_cluster | `Failure` | 496.08 | test_kubernetes_clusters.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
test_01_sys_vm_start | `Failure` | 0.14 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.18 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.08 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.05 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.05 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.53 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.54 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.56 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.55 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.34 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.34 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 18.92 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.48 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.14 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.41 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 2.17 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1514.92 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694810121
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#discussion_r619255987
##########
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##########
@@ -1321,6 +1332,87 @@ public Host maintain(final PrepareForMaintenanceCmd cmd) {
}
}
+ /**
+ * Declares host as Degraded. This method is used in critical situations; e.g. if it is not possible to start host, not even via out-of-band.
+ */
+ @Override
+ public Host declareHostAsDegraded(final DeclareHostAsDegradedCmd cmd) throws NoTransitionException {
+ Long hostId = cmd.getId();
+ HostVO host = _hostDao.findById(hostId);
+
+ if (host == null || host.getRemoved() != null) {
+ throw new InvalidParameterValueException(String.format("Host [id:%s] does not exist", host.getId()));
Review comment:
Good idea, I have updated the code; however, it still necessary to log just the ID either if the host is null or the hostname is null/blank, assuming that the user has provided an ID that does not result in a valid Host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894217491
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849180646
@PaulAngus just to be clear, I am not touching on the `HAState`, but instead on the `ResourceState`. And this has specific reasons that I hope will be clarified with this answer.
I am sorry for any confusion that might be due to the naming that was chosen; I can change the whole context from declaring host as `Degraded` to other options, such as `Problematic`, or any other word (initially it was `Dead`, but it was changed to a better word).
With that said, I totally agree with you when you say that this implementation adds complexity to an already convoluted execution flow. But out of all the options I imagine it to be one of the best options.
I created `ResourceState.Degraded` to keep the current HA state machine as it is, avoiding higher complexity and eventual issues. On top of that, the proposed state `ResourceState.Degraded` creates a unique case, where instead of the CloudStack HA defining a problematic host, the Admin places the Host as _Degraded_. This is something that helps on tracking what is happening and also to get back the host from the `ResourceState.Degraded` state to `ResourceState.Enabled`, or `ResourceState.Maintenance`.
Additionally, your idea of "forcing" transiting the `HAState` to a state that would lead to either `Fencing` or `Recovering` the host is quite interesting but has a few issues.
1. the `HAState.Degraded` state does not allow transiting to `HAState.Recovering` neither to `HAState.Fencing`. Here is how the `HAState.Degraded` state transition table works:
```
+----------+---------------------------------------+------------+
| State | Event | Next State |
+----------+---------------------------------------+------------+
| Degraded | Event.Disabled | Disabled |
+----------+---------------------------------------+------------+
| Degraded | Event.Ineligible | Ineligible |
+----------+---------------------------------------+------------+
| Degraded | Event.HealthCheckFailed | Degraded |
+----------+---------------------------------------+------------+
| Degraded | Event.HealthCheckPassed | Available |
+----------+---------------------------------------+------------+
| Degraded | Event.PeriodicRecheckResourceActivity | Suspect |
+----------+---------------------------------------+------------+
```
See: https://github.com/apache/cloudstack/blob/master/api/src/main/java/org/apache/cloudstack/ha/HAConfig.java
2. the HA state machine allows transiting to `HAState.Recovering` via `HAState.Checking`, when a threshold of failures is reached; which is not feasible to do in the specific situation that this PR has been designed to handle
```
+----------+------------------------------------------------+------------+
| State | Event | Next State |
+----------+------------------------------------------------+------------+
| Checking | Event.Disabled | Disabled |
+----------+------------------------------------------------+------------+
| Checking | Event.Ineligible | Ineligible |
+----------+------------------------------------------------+------------+
| Checking | Event.TooFewActivityCheckSamples | Suspect |
+----------+------------------------------------------------+------------+
| Checking | Event.ActivityCheckFailureUnderThresholdRatio | Degraded |
+----------+------------------------------------------------+------------+
| Checking | Event.ActivityCheckFailureOverThresholdRatio | Recovering |
+----------+------------------------------------------------+------------+.
```
3. the HA State machine was designed with the only purpose of being an automated system in which the transitions are all based on failure checks; therefore, adding a manual operation is quite hard and might do more harm than good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669550076
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650632802
Packaging result: ✔centos7 ✔debian. JID-1475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712776233
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-724927911
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694875273
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678758798
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678489932
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724511
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-709536480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725465070
I don't think we should wait any longer @GabrielBrascher , tested by 3rd party and two lgtm???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#discussion_r617246967
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/host/CancelHostAsDegradedCmd.java
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.host;
+
+import com.cloud.event.EventTypes;
+import com.cloud.host.Host;
+import com.cloud.utils.fsm.NoTransitionException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = "cancelHostAsDegraded",
+ description = "Cancel host status from 'Degraded'. Host will transit back to status 'Enabled'.",
+ since = "4.15.0.0",
Review comment:
change this to 4.16?
##########
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##########
@@ -1321,6 +1332,87 @@ public Host maintain(final PrepareForMaintenanceCmd cmd) {
}
}
+ /**
+ * Declares host as Degraded. This method is used in critical situations; e.g. if it is not possible to start host, not even via out-of-band.
+ */
+ @Override
+ public Host declareHostAsDegraded(final DeclareHostAsDegradedCmd cmd) throws NoTransitionException {
+ Long hostId = cmd.getId();
+ HostVO host = _hostDao.findById(hostId);
+
+ if (host == null || host.getRemoved() != null) {
+ throw new InvalidParameterValueException(String.format("Host [id:%s] does not exist", host.getId()));
Review comment:
Better to display hostname instead of id?
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/host/DeclareHostAsDegradedCmd.java
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.host;
+
+import com.cloud.event.EventTypes;
+import com.cloud.host.Host;
+import com.cloud.utils.fsm.NoTransitionException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = "declareHostAsDegraded",
+ description = "Declare host as 'Degraded'. Host must be on 'Disconnected' or 'Alert' state. The ADMIN must be sure that there are no VMs running on the respective host otherwise this command might corrupted VMs that were running on the 'Degraded' host.",
+ since = "4.15.0.0",
Review comment:
same here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894073021
<b>Trillian Build Failed (tid-1510)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849574625
@DaanHoogland, no changes since your review. Just addressed @ravening comments, including update the API version for `4.16.0.0` as it was no longer going to `4.15.0.0`.
Maybe renaming the name of the created `ResourceState`, as I now realize this can cause some confusion with the `HAState`. But maybe it is OK as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678638801
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894551600
<b>Trillian test result (tid-1515)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34948 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4111-t1515-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-658968205
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-658967505
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678525214
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725484729
As this is a new feature, and we are in the code freeze right now.... finish the sentence on your own ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712864190
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669550076
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712776233
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893218210
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893917975
<b>Trillian test result (tid-1483)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61481 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4111-t1483-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 79 look OK, 10 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 354.02 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 1123.76 | test_privategw_acl.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 95.46 | test_routers_network_ops.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_01_create_template | `Error` | 65.77 | test_templates.py
test_CreateTemplateWithDuplicateName | `Error` | 17.45 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.37 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.38 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.37 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.42 | test_templates.py
test_03_delete_template | `Error` | 11.88 | test_templates.py
test_04_extract_template | `Failure` | 1.06 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_template_usage | `Error` | 231.24 | test_usage.py
test_01_volume_usage | `Failure` | 787.13 | test_usage.py
test_10_attachAndDetach_iso | `Failure` | 1531.32 | test_vm_life_cycle.py
test_06_download_detached_volume | `Failure` | 302.34 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725496123
@DaanHoogland as Andrea says this is a new feature which has missed to code freeze date. As RM I'm afraid that I can't let it in. cc @GabrielBrascher
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725453266
@RodrigoDLopez tested and reviewed with a **+1**, therefore there are already 2 LGTMs. However, it would be nice to have more reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653730275
Packaging result: ✔centos7 ✖debian. JID-1522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894217130
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724542
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-893210471
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-878194362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-878700686
<b>Trillian test result (tid-1234)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44490 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4111-t1234-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_VPC_nics_after_destroy | `Failure` | 971.60 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 974.33 | test_vpc_router_nics.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.25 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678489932
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725476568
@DaanHoogland the respective review was on Jun 19, the first comment at this PR. However, it was before changes on the command and state name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694809757
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-667085891
@wido that is a nice set of options, thanks!
I am looking for a generic term of telling that the Host needs some attention from Admins(could be anything as: application, network, hardware, etc). It also must be totally different from current options for host/agent status (e.g. _Down_, _Disconnected_, and _Alert_).
With that in mind, _Offline_ or _Unavailable_ might bring confusion regarding the existing _Disconnect_ and _Down_ states. On the other way, _Defect_ seems a good option; I also like _Problematic_.
A nice option would also be [Degraded](https://github.com/apache/cloudstack/blob/36ef85012f69af59657c87ad88184769549d8792/api/src/main/java/org/apache/cloudstack/ha/HAConfig.java#L69), it already is used by [HAConfig.java](https://github.com/apache/cloudstack/blob/36ef85012f69af59657c87ad88184769549d8792/api/src/main/java/org/apache/cloudstack/ha/HAConfig.java) to say that a Host needs to be fenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849565578
Do I need to re-review @GabrielBrascher ? anything new here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-660562549
Ping for review @rhtyd @kiwiflyer @nathanejohnson @DaanHoogland @nvazquez @svenvogel @andrijapanicsb and others :slightly_smiling_face:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-724973047
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-894053692
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665535646
Like your thinking, mr operator ;).
one reservation @GabrielBrascher; is the word 'dead' the best to use here? the life/dead metaphore for hosts might incite associations that are not fit for purpose. is it an idea to find some other word to use, like 'broken' or 'corrupted'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-669549894
@DaanHoogland @wido updated PR replacing "Dead" with "Degraded".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-725239635
<b>Trillian test result (tid-3144)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4111-t3144-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678638664
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712791941
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-658967505
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-892815730
@RodrigoDLopez @rhtyd this one would still be relevant for some scenarios.
It is proposed as an alternative when clusters have no HA enabled or the HA is not detecting a host as problematic but ADMINS are aware of the situation and then decide to use this API command to manually "fence" the host.
Thanks for the review/testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-849012497
I am becoming that guy that annoys the others by constantly pinging for review: @DaanHoogland @andrijapanicsb @PaulAngus @svenvogel @RodrigoDLopez @GutoVeronezi @weizhouapache @ravening @rhtyd @GutoVeronezi & others
This one is laying down for a while, I appreciate any feedback.
Thanks in advance :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-712776679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-658988577
Packaging result: ✔centos7 ✔debian. JID-1582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694823804
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4111: API-call to declare host as Degraded
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-694875978
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-650628399
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org