You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/05 10:48:37 UTC
[GitHub] [couchdb] big-r81 opened a new pull request, #4288: Spidermonkey version NIF
big-r81 opened a new pull request, #4288:
URL: https://github.com/apache/couchdb/pull/4288
## Overview
Created an Erlang NIF to get the Spidermonkey version from the linked library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4288: Spidermonkey version NIF
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #4288:
URL: https://github.com/apache/couchdb/pull/4288#issuecomment-1658668391
It's a neat patch as it shows the exact version of SM, and presumably might show if somehow the build was misconfigured (we thought we built it with SM 78 but actually built it with 96). But I don't know if it's worth having one extra NIFs in the system just for that. So I am more inclined not to have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson commented on pull request #4288: Spidermonkey version NIF
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #4288:
URL: https://github.com/apache/couchdb/pull/4288#issuecomment-1658839091
I'm inclined against for same reason. if it were in the same `./src/couch/priv/couch_js` pile of native code then maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson commented on pull request #4288: Spidermonkey version NIF
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #4288:
URL: https://github.com/apache/couchdb/pull/4288#issuecomment-1658088383
not sure I understand the need. couchdb is built against a specific version of spidermonkey, isn't it? can it change at runtime without breaking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4288: Spidermonkey version NIF
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4288:
URL: https://github.com/apache/couchdb/pull/4288#issuecomment-1658928035
It's fine be me too, to not having an extra nif. Before this PR, I backported this logic into `./couchjs -V` to print this version information from the command line. See #4262 for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 closed pull request #4288: Spidermonkey version NIF
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 closed pull request #4288: Spidermonkey version NIF
URL: https://github.com/apache/couchdb/pull/4288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #4288: Spidermonkey version NIF
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on PR #4288:
URL: https://github.com/apache/couchdb/pull/4288#issuecomment-1658027064
@nickva @rnewson do we want to use this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org