You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/03 19:12:48 UTC

[GitHub] marcoabreu commented on a change in pull request #10797: Better cleaning of git repo, signal handlers

marcoabreu commented on a change in pull request #10797: Better cleaning of git repo, signal handlers
URL: https://github.com/apache/incubator-mxnet/pull/10797#discussion_r185907848
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -353,7 +369,18 @@ sanity_check() {
 }
 
 
+
+before_unittest() {
 
 Review comment:
   I don't think this is necessary since it can be retrieved from the log and adds boilerplate to the the functions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services