[jira] [Comment Edited] (TEZ-2410) VertexGroupCommitFinishedEvent is not logged correctly

["Jeff Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531728#comment-14531728 ] 

Jeff Zhang edited comment on TEZ-2410 at 5/7/15 12:00 AM:
----------------------------------------------------------

bq. Why is this the case? Why do we not log vertex group finished when we commit groups upon dag completion? Is there any harm even if we do? If not then why not do it? 
There's 3 possible region would cause recovered failure due to in COMMITTING.
* Between VertexGroupCommitStartedEvent and VertexGroupCommitFinishedEvent   (For each  vertex group commit onVertexSuccess)
* Between VertexCommitStartedEvent and VertexFinishedEvent (For each vertex commit on VertexSuccess)
* Between DAGCommitStartedEvent and DAGCommitFinishedEvent       (For commit onDAGSuccess)  

So if it is commit onDAGSuccess, we don't need to log VertexGroupCommitEvent. ( IAC, I will add unit test to verify the second and third case)

bq. So we dont need to add a duplicate enum because its logic is completely captured by other means.
Got it, will fix it. 


was (Author: zjffdu):
bq. Why is this the case? Why do we not log vertex group finished when we commit groups upon dag completion? Is there any harm even if we do? If not then why not do it? 
There's 2 possible region would cause recovered failure due to in COMMITTING.
* Between VertexGroupCommitStartedEvent and VertexGroupCommitFinishedEvent   (For commit onVertexSuccess)
* Between DAGCommitStartedEvent and DAGCommitFinishedEvent       (For commit onDAGSuccess)  

So if it is commit onDAGSuccess, we don't need to log VertexGroupCommitEvent. ( IAC, I will add unit test to verify DAGCommitStartedEvent & DAGCommitFinishedEvent)

bq. So we dont need to add a duplicate enum because its logic is completely captured by other means.
Got it, will fix it. 

> VertexGroupCommitFinishedEvent is not logged correctly
> ------------------------------------------------------
>
>                 Key: TEZ-2410
>                 URL: https://issues.apache.org/jira/browse/TEZ-2410
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>            Priority: Blocker
>         Attachments: TEZ-2410-1.patch, TEZ-2410-1.patch
>
>
> VertexGroupCommitFinishedEvent may be logged for non-vertex group commits.
> VertexGroupCommitFinishedEvent may be logged for each member vertex of the group instead of once per group.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)