You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2012/08/22 01:19:26 UTC

svn commit: r1375847 - in /jmeter/trunk/src/core/org/apache/jmeter/samplers: RemoteListenerWrapper.java RemoteSampleListener.java

Author: sebb
Date: Tue Aug 21 23:19:26 2012
New Revision: 1375847

URL: http://svn.apache.org/viewvc?rev=1375847&view=rev
Log:
Code comments

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteListenerWrapper.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteSampleListener.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteListenerWrapper.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteListenerWrapper.java?rev=1375847&r1=1375846&r2=1375847&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteListenerWrapper.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteListenerWrapper.java Tue Aug 21 23:19:26 2012
@@ -130,6 +130,9 @@ public class RemoteListenerWrapper exten
      * {@inheritDoc}
      */
     public void testIterationStart(LoopIterationEvent event) {
+        // Not implemented, probably because of high overheads
+        // At present there are no Remoteable classes that use the method
+        // so RemoteSampleListener does not implement it either
     }
 
 }
\ No newline at end of file

Modified: jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteSampleListener.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteSampleListener.java?rev=1375847&r1=1375846&r2=1375847&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteSampleListener.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/samplers/RemoteSampleListener.java Tue Aug 21 23:19:26 2012
@@ -37,6 +37,11 @@ public interface RemoteSampleListener ex
 
     public void testEnded(String host) throws RemoteException;
 
+    // Not currently needed by any Remoteable classes
+    // Anyway, would probably be too expensive in terms of network traffic
+    // 
+    // public void testIterationStart(LoopIterationEvent event);
+    
     /**
      * This method is called remotely and fires a list of samples events
      * recieved locally. The function is to reduce network load when using