[jira] [Resolved] (IMPALA-1729) StringParser::StringToFloatInternal() can be optimized

["Dan Hecht (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Hecht resolved IMPALA-1729.
-------------------------------
    Resolution: Won't Fix

Nothing really actionable here.

> StringParser::StringToFloatInternal() can be optimized
> ------------------------------------------------------
>
>                 Key: IMPALA-1729
>                 URL: https://issues.apache.org/jira/browse/IMPALA-1729
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 2.1
>            Reporter: Skye Wanderman-Milne
>            Priority: Minor
>              Labels: performance, ramp-up
>         Attachments: string-parser-benchmark.cc
>
>
> I've attached a quick benchmark that can be used to compare different implementations. Note that for me, this benchmark is always a bit noisy -- I see ~10 iters/ms variance between runs. The first two implementations compare the original vs. the patch for IMPALA-1622, and the third is a (possibly incorrect) optimized version (I think the sig figs accounting is slightly off).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)