You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/12 21:25:08 UTC

[GitHub] [pulsar] MarvinCai opened a new pull request #4265: [transaction][acknowledge] Introduce PENDING_ACK state in acknowledgement path

MarvinCai opened a new pull request #4265: [transaction][acknowledge] Introduce PENDING_ACK state in acknowledgement path
URL: https://github.com/apache/pulsar/pull/4265
 
 
   Master Issue: #2664
   
   Motivation:
   Add acknowledgeMessage, commit, abort for transaction in PersistentSubscription.
   
   Changes:
   Will put message in Pending_ACK status when acknowledgeMessage is called with TxnID.
   No real status class introduced, only added collection to hold messages in Pending_ACK status.
   
   Add commitTxn to put message to Deleted status.
   Add abortTxn to put message to Pending status.
   
   For normal acknowledgeMessage and redeliverUnacknowledgedMessages, will check to see if 
   message if message is in Pending_ACK first. If true, will **ignore** those acks/redeliverys.
   
   Add unit test.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services