You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "shoothzj (via GitHub)" <gi...@apache.org> on 2024/04/16 12:08:29 UTC
[PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
shoothzj opened a new pull request, #4296:
URL: https://github.com/apache/bookkeeper/pull/4296
### Motivation
Current scheduling mechanism for garbage collection uses scheduleAtFixedRate. This approach schedules the next execution without considering whether the current task has finished, potentially leading to overlapping executions if a task takes longer than expected.
In my test environment, After task accumulation in gc thread pool, sometimes there is no entrylog to extract and no entrylogger to compact. But every round of gc, still need to compare ledger meta between local and metadata store (zk), which will result in highly frequently access to metadata store and each access will bring considerable unnecessary data flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4296:
URL: https://github.com/apache/bookkeeper/pull/4296#issuecomment-2065538967
@nicoloboschi @hangc0276 @merlimat @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #4296:
URL: https://github.com/apache/bookkeeper/pull/4296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4296:
URL: https://github.com/apache/bookkeeper/pull/4296#issuecomment-2060095568
@nicoloboschi @hangc0276 @merlimat @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4296:
URL: https://github.com/apache/bookkeeper/pull/4296#issuecomment-2065618510
@nicoloboschi @eolivelli @hangc0276 @merlimat @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4296:
URL: https://github.com/apache/bookkeeper/pull/4296#issuecomment-2066816433
@nicoloboschi @eolivelli @hangc0276 @merlimat @zhaijack @dlg99 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org