You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (Created) (JIRA)" <ji...@apache.org> on 2012/03/20 19:01:39 UTC
[jira] [Created] (HIVE-2883) Metastore client doesnt close
connection properly
Metastore client doesnt close connection properly
-------------------------------------------------
Key: HIVE-2883
URL: https://issues.apache.org/jira/browse/HIVE-2883
Project: Hive
Issue Type: Bug
Reporter: Ashutosh Chauhan
While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
{code}
12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan resolved HIVE-2883.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.9.1)
(was: 0.10.0)
0.9.0
Checked-in 0.9 branch.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2883:
-----------------------------------
Fix Version/s: (was: 0.9.0)
Unlinking from 0.9.0 release
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Thomas Weise (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Weise updated HIVE-2883:
-------------------------------
Fix Version/s: 0.9.1
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259934#comment-13259934 ]
Phabricator commented on HIVE-2883:
-----------------------------------
cwsteinbach has accepted the revision "HIVE-2883 [jira] Metastore client doesnt close connection properly".
+1. Please commit.
REVISION DETAIL
https://reviews.facebook.net/D2613
BRANCH
svn
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260297#comment-13260297 ]
Hudson commented on HIVE-2883:
------------------------------
Integrated in Hive-trunk-h0.21 #1392 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1392/])
HIVE-2883 [jira] Metastore client doesnt close connection properly
Summary:
https://issues.apache.org/jira/browse/HIVE-2883
Here is the patch which gets rid of this problem as per my hypothesis. I also
tested it and the above noted stack trace doesnt occur anymore.
While closing connection, it always fail with following trace. Seemingly, it
doesnt have any harmful effects.
12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore
client
org.apache.thrift.transport.TTransportException: Cannot write to null
outputStream
at
org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
at
org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
at
org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at
com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
Test Plan: EMPTY
Reviewers: JIRA, cwsteinbach
Reviewed By: cwsteinbach
Differential Revision: https://reviews.facebook.net/D2613 (Revision 1329461)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329461
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246546#comment-13246546 ]
Ashutosh Chauhan commented on HIVE-2883:
----------------------------------------
My analysis is client already knows about transport, so inside client.shutdown() it is calling transport.close() which closes underlying outputstream. So, we *should* not do transport.close() ourselves in HiveMetaStoreClient.close() ? But, I can't be sure of this hypothesis since implementation of client.shutdown() is in FaceBookService.client (which is in libfb303.jar) I cant seem to find sources for this class anywhere.
So, I request Facebook contributors of Hive project to either fix this bug or release sources of libfb303.jar so that I can verify and fix this myself.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Thomas Weise (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Weise reopened HIVE-2883:
--------------------------------
Reopening for backport to 0.9 branch.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2883:
-----------------------------------
Component/s: Metastore
Affects Version/s: 0.9.0
Fix Version/s: 0.9.0
Looks like client.shutdown() is unnecessarily called after client.close() I guess only one of those calls will suffice.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Mithun Radhakrishnan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254899#comment-13254899 ]
Mithun Radhakrishnan commented on HIVE-2883:
--------------------------------------------
+1
Good fix, this. Takes care of HCATALOG-236 as well.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2883:
------------------------------
Attachment: HIVE-2883.D2613.1.patch
ashutoshc requested code review of "HIVE-2883 [jira] Metastore client doesnt close connection properly".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2883
Here is the patch which gets rid of this problem as per my hypothesis. I also tested it and the above noted stack trace doesnt occur anymore.
While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2613
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5985/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2883:
-----------------------------------
Status: Patch Available (was: Open)
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Travis Crawford (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246636#comment-13246636 ]
Travis Crawford commented on HIVE-2883:
---------------------------------------
@ashutosh - fb303 is released as a thrift contrib project:
http://svn.apache.org/viewvc/thrift/trunk/contrib/fb303/
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246692#comment-13246692 ]
Ashutosh Chauhan commented on HIVE-2883:
----------------------------------------
Nopes, this location doesnt have it. It just has abstract class FaceBookBase.java I am looking for its implemetation that is FaceBookService.java Do you know where is that?
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2883:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Status: Resolved (was: Patch Available)
Committed to trunk.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan reassigned HIVE-2883:
--------------------------------------
Assignee: Ashutosh Chauhan
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259971#comment-13259971 ]
Phabricator commented on HIVE-2883:
-----------------------------------
ashutoshc has committed the revision "HIVE-2883 [jira] Metastore client doesnt close connection properly".
Change committed by hashutosh.
REVISION DETAIL
https://reviews.facebook.net/D2613
COMMIT
https://reviews.facebook.net/rHIVE1329461
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246673#comment-13246673 ]
Ashutosh Chauhan commented on HIVE-2883:
----------------------------------------
Thanks, Travis for pointing this out. I will take a look.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Fix For: 0.9.0
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255747#comment-13255747 ]
Ashutosh Chauhan commented on HIVE-2883:
----------------------------------------
Hive Committers,
This has been independently verified by couple other folks. Can someone review it for me?
All tests passed with the patch.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2883) Metastore client doesnt close
connection properly
Posted by "Travis Crawford (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250953#comment-13250953 ]
Travis Crawford commented on HIVE-2883:
---------------------------------------
I patched this in and ran a pig query through HCatalog, and the "Unable to shutdown local metastore client" error went away, and the query produced a correct result. LGTM.
> Metastore client doesnt close connection properly
> -------------------------------------------------
>
> Key: HIVE-2883
> URL: https://issues.apache.org/jira/browse/HIVE-2883
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2883.D2613.1.patch
>
>
> While closing connection, it always fail with following trace. Seemingly, it doesnt have any harmful effects.
> {code}
> 12/03/20 10:55:02 ERROR hive.metastore: Unable to shutdown local metastore client
> org.apache.thrift.transport.TTransportException: Cannot write to null outputStream
> at org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
> at org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
> at org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
> at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:421)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:415)
> at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:310)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira