You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 09:34:31 UTC
[GitHub] [incubator-superset] blcksrx opened a new pull request #9013: set
SUPERSET_WEBSERVER timeout for urllib opener
blcksrx opened a new pull request #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
In the scheduler, there is an urllib opener exists that get data and email it from the superset URL. so the timeout of this opener should be set SUPERSET_WEBSERVER
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9013: set SUPERSET_WEBSERVER timeout for urllib opener
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013#discussion_r370813660
##########
File path: superset/tasks/schedules.py
##########
@@ -258,7 +258,7 @@ def _get_slice_data(schedule):
opener = urllib.request.build_opener()
opener.addheaders.append(("Cookie", f"session={cookies['session']}"))
- response = opener.open(slice_url)
+ response = opener.open(slice_url, timeout=config["SUPERSET_WEBSERVER_TIMEOUT"])
Review comment:
Does this solve a problem that you're facing? Based on the documentation, leaving timeout unset never triggers a timeout: https://docs.python.org/3/library/socket.html?highlight=socket#socket.getdefaulttimeout This leaves me to conclude that the timeout is thrown once the webserver's own timeout is reached, rendering this timeout setting obsolete. Is this not the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] blcksrx closed pull request #9013: set
SUPERSET_WEBSERVER timeout for urllib opener
Posted by GitBox <gi...@apache.org>.
blcksrx closed pull request #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9013: set
SUPERSET_WEBSERVER timeout for urllib opener
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013#issuecomment-578481798
@blcksrx did you check my comment above? It is my understanding that this change is not necessary unless the default timeout has been altered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9013: set
SUPERSET_WEBSERVER timeout for urllib opener
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013#issuecomment-578076141
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=h1) Report
> Merging [#9013](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1c931ff0d38b4815a4c867c25e2b1bbf5569d4?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9013 +/- ##
==========================================
- Coverage 59.16% 59.15% -0.02%
==========================================
Files 367 367
Lines 11680 11682 +2
Branches 2863 2864 +1
==========================================
Hits 6910 6910
- Misses 4591 4593 +2
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9013/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `54.32% <0%> (-1.38%)` | :arrow_down: |
| [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9013/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `47.94% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=footer). Last update [6f1c931...2b3ad74](https://codecov.io/gh/apache/incubator-superset/pull/9013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] blcksrx commented on issue #9013: set
SUPERSET_WEBSERVER timeout for urllib opener
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013#issuecomment-578669382
I'm sorry. yes, you are right.
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org