You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Paul Yang (JIRA)" <ji...@apache.org> on 2010/08/25 02:33:19 UTC

[jira] Created: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

DistributedRaidFileSystem not removed from cache on close()
-----------------------------------------------------------

                 Key: MAPREDUCE-2029
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: contrib/raid
    Affects Versions: 0.22.0
            Reporter: Paul Yang


When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.

Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915980#action_12915980 ] 

dhruba borthakur commented on MAPREDUCE-2029:
---------------------------------------------

+1, good catch. can you pl post HudsonQA results for this one?

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>         Attachments: MAPREDUCE-2029.patch
>
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramkumar Vadali updated MAPREDUCE-2029:
---------------------------------------

    Assignee: Ramkumar Vadali

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur resolved MAPREDUCE-2029.
-----------------------------------------

     Hadoop Flags: [Reviewed]
    Fix Version/s: 0.22.0
       Resolution: Fixed

I just committed this. Thanks Ram!

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2029.patch
>
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916319#action_12916319 ] 

Ramkumar Vadali commented on MAPREDUCE-2029:
--------------------------------------------

Test results
=========


ant test-patch:

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================

ant test:

All passed except TestUlimit, which is an unrelated failure.

This is a one-line fix which does not need a unit-test.

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>         Attachments: MAPREDUCE-2029.patch
>
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926087#action_12926087 ] 

Hudson commented on MAPREDUCE-2029:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
    

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2029.patch
>
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2029) DistributedRaidFileSystem not removed from cache on close()

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramkumar Vadali updated MAPREDUCE-2029:
---------------------------------------

    Attachment: MAPREDUCE-2029.patch

Call super.close()

> DistributedRaidFileSystem not removed from cache on close()
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/raid
>    Affects Versions: 0.22.0
>            Reporter: Paul Yang
>            Assignee: Ramkumar Vadali
>         Attachments: MAPREDUCE-2029.patch
>
>
> When DistributedRaidFileSystem.close() is called, it does not remove itself from the FileSystem cache, but it does close the underlying filesystem, e.g. DFS.
> Because the DRFS with the closed DFS is still in the cache, calling FileSystem.get() returns a stale DRFS that throws 'filesystem closed' exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.