You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2017/01/03 15:24:19 UTC
[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1383
NIFI-2859 - Ignore files starting with a dot in ListHDFS
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-2859
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1383
----
commit 7c412bea46ea568b24e6589759054a8babcd1a5e
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-01-03T15:22:11Z
NIFI-2859 - Ignore files starting with a dot in ListHDFS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1383: NIFI-2859 - Ignore files starting with a dot in ListHDFS
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1383
@pvillard31 @bbende LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1383: NIFI-2859 - Ignore files starting with a dot in ListHDFS
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1383
+1 merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1383#discussion_r94950985
--- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java ---
@@ -176,7 +176,7 @@ private HDFSListing deserialize(final String serializedState) throws JsonParseEx
// Build a sorted map to determine the latest possible entries
for (final FileStatus status : statuses) {
- if (status.getPath().getName().endsWith("_COPYING_")) {
+ if (status.getPath().getName().endsWith("_COPYING_") || status.getPath().getName().startsWith(".")) {
--- End diff --
I think we should try to be consistent with how ListFile works. It has a property to apply a regex to filer filenames and the default value is anything that doesn't start with a dot:
```
public static final PropertyDescriptor FILE_FILTER = new PropertyDescriptor.Builder()
.name("File Filter")
.description("Only files whose names match the given regular expression will be picked up")
.required(true)
.defaultValue("[^\\.].*")
.addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR)
.build();
```
This way the user can determine if they want dot files or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1383#discussion_r94956675
--- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java ---
@@ -176,7 +176,7 @@ private HDFSListing deserialize(final String serializedState) throws JsonParseEx
// Build a sorted map to determine the latest possible entries
for (final FileStatus status : statuses) {
- if (status.getPath().getName().endsWith("_COPYING_")) {
+ if (status.getPath().getName().endsWith("_COPYING_") || status.getPath().getName().startsWith(".")) {
--- End diff --
@bbende Yes you're right! Otherwise there is the following in GetHDFS:
````java
public static final PropertyDescriptor IGNORE_DOTTED_FILES = new PropertyDescriptor.Builder()
.name("Ignore Dotted Files")
.description("If true, files whose names begin with a dot (\".\") will be ignored")
.required(true)
.allowableValues("true", "false")
.defaultValue("true")
.build();
````
But the filter property is much better. I'll update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1383: NIFI-2859 - Ignore files starting with a dot in ListHDFS
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1383
@bbende: I added the file filter property as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---