[jira] [Created] (CB-13592) comment is not removed on removing embedded frameworks

["Kelvin Ho (JIRA)" <ji...@apache.org>]

Kelvin Ho created CB-13592:
------------------------------

             Summary:  comment is not removed on removing embedded frameworks
                 Key: CB-13592
                 URL: https://issues.apache.org/jira/browse/CB-13592
             Project: Apache Cordova
          Issue Type: Bug
          Components: cordova-node-xcode
    Affects Versions: Master
         Environment: Mac OS high Sierra.

            Reporter: Kelvin Ho
            Assignee: Anis Kadri
             Fix For: Master


Currently after adding an embedded framework, 4 entries are added to the PBXBuildFileSection.

{{        "128CD4F705D24987A12F213E": {
          "isa": "PBXBuildFile",
          "fileRef": "021AA25C78F942DA94C24904",
          "fileRef_comment": "EmbedThirdParty.framework"
        },
        "128CD4F705D24987A12F213E_comment": "EmbedThirdParty.framework in Frameworks",
        "B9B17AE7AA7C4663BA933B64": {
          "isa": "PBXBuildFile",
          "fileRef": "021AA25C78F942DA94C24904",
          "fileRef_comment": "EmbedThirdParty.framework",
          "settings": {
            "ATTRIBUTES": ["CodeSignOnCopy"]
          }
        },
        "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",}}

After calling removeFramework function, the current existing code will incorrectly leave a orphan entry in the PBXFileSection:

{{        "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",}}

Pull request #5 fixes this issue, and adds a relevant unit test in removeFramework.js
https://github.com/apache/cordova-node-xcode/pull/5



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org