You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Lars Francke (JIRA)" <ji...@apache.org> on 2010/02/23 23:54:27 UTC
[jira] Created: (HBASE-2254) Improvements to the Maven POMs
Improvements to the Maven POMs
------------------------------
Key: HBASE-2254
URL: https://issues.apache.org/jira/browse/HBASE-2254
Project: Hadoop HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.21.0
Reporter: Lars Francke
Priority: Minor
While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
* The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
* I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
* I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
* I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
* I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
I'll continue to go over it but perhaps it already helps.
I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-2254:
--------------------------------
Attachment: HBASE-2254-4.patch
Just a couple more changes:
* Reworked the transactional and core pom to use dependencyManagement
* Removed groupId where possible (it is inherited by the parent)
There are more things to be done but that'll have to wait till tomorrow.
I tested the tar build and it worked.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-2254:
--------------------------------
Attachment: hbase2254.sh
HBASE-2254-5.patch
* Removed the dependency from HDFS 0.22 - I assume this was by accident or do we really need this?
* Included all developers from http://hadoop.apache.org/hbase/credits.html. I also included organizations and emails for those
** I took the email adresses from the JIRA accounts, don't know if it is a good idea to include the addresses
** I included the organizations - don't really know if these are still current
** maven also has the option for <contributors> but I think that'd be overkill
* Added a link to hudson
* Added links to the mailing lists
* Reformatted the stargate pom
* Removed unnecessary configuration options for the javadoc plugin, added the processing of doc-files directories
I also attached a script that does the necessary cleanups and moves in Subversion. If you decide to keep the ant and ivy scripts for now you can just comment out that part.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837885#action_12837885 ]
Lars Francke commented on HBASE-2254:
-------------------------------------
Thanks! It wouldn't have been possible without Paul's work on this. It's far easier now to fix the smaller things after he has done the grunt work.
Please wait a bit longer (well it might be a day because of our time zone difference) as there are still a few things to do. One of those things is to shuffle around the contribs to adhere to the Maven directory layout. This will unfortunately mean that we'll (or better yet... you) have to do a bunch of subversion copying and moving around once again. Better do it now than later. I'll comment again when I think the patch is ready to go.
I'll open a new issue for the Ant/Ivy stuff and attach a patch.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-2254:
--------------------------------
Attachment: hbase-2254-3.patch
This new patch has these additional changes (in comparison to the -2 version)
* Comment about old slf4j version removed. A new one is pulled in for Thrift anyway.
* JRuby was commented out. It is needed for the shell.
* I updated JRuby to 1.4.0 which was released in last November (easy to undo if you don't want to upgrade)
* Readded the assembly plugin to the main pom file
* Updated assembly plugin to 2.2-beta-5, Paul had a comment in there that it wouldn't download for him but it works perfect from here so I'll assume it was a temporary glitch
* Added the replication contrib output to the final tar file
* Fixed the assembly descriptor XML, reformatted it a bit
* Once again include the base directory in the final tar file (so that when you use tar xvfz it extracts into a hbase-x.xx.x directory
* Introduced a dependencyManagement section in the main POM for common dependencies, replaced org.apache.hbase with ${project.groupId}
* Reworked the replication POM to use the dependencyManagement features
Just a heads up: The final tar size has gone up to about 80 MB because the dependencies are duplicated for the stargate contrib at the moment. All this will probably have to be tuned quite a bit. So this is once again not a final version. I'll keep on working on it tomorrow if no one has done it until then.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837993#action_12837993 ]
stack commented on HBASE-2254:
------------------------------
I added these files too:
{code}
Adding contrib/mdc_replication/pom.xml
Adding core/src/main/resources/webapps/master/WEB-INF/web.xml
Adding core/src/main/resources/webapps/regionserver/WEB-INF/web.xml
{code}
Seems like they are needed.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke resolved HBASE-2254.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Assignee: Lars Francke
I'll open another ticket. That makes it easier to follow what has changed.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-2254:
--------------------------------
Attachment: hbase-2254-1.patch
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837502#action_12837502 ]
Lars Francke commented on HBASE-2254:
-------------------------------------
Ah! That was on my list too! I wondered why that was missing.
I have a few more things to add to the patch, I'll upload a new version later.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2254) Improvements to the Maven POMs
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-2254:
--------------------------------------
Attachment: HBASE-2254-2.patch
Attaching the same patch + the missing pom for replication and my entry in the main pom file.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837910#action_12837910 ]
Kay Kay commented on HBASE-2254:
--------------------------------
Tried out the latest one. It works great. Great work - Paul , Lars and Patrick.
Agree that fixing ant/ivy at this point is a waste of time and removing it is better.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Paul Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837513#action_12837513 ]
Paul Smith commented on HBASE-2254:
-----------------------------------
looks good to me. TextMate is to blame for the whitespace formatting, it really screwed the pooch with respect to the jspc stuff, I was using the Auto-format feature of TextMate and that's what comes out, appreciate the tidy up.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837498#action_12837498 ]
Jean-Daniel Cryans commented on HBASE-2254:
-------------------------------------------
I'll add to that patch the pom for replication.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Patrick Angeles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837808#action_12837808 ]
Patrick Angeles commented on HBASE-2254:
----------------------------------------
Great work guys.
I'm using the maven-eclipse-plugin and this section in hbase-core/pom.xml prevented the plugin from adding src/main/java to the classpath:
<resources>
<resource>
<directory>src/main/resources</directory>
</resource>
<resource>
<directory>src/main/</directory>
<includes>
<include>webapps/**/*.gif</include>
<include>webapps/**/*.css</include>
<include>webapps/**/*.html</include>
<include>webapps/**/*.xml</include>
</includes>
</resource>
</resources>
The result .classpath file is:
... snip ...
<classpathentry kind="src" path="src/test/java" output="target/test-classes" including="**/*.java"/>
<classpathentry kind="src" path="src/test/resources" output="target/test-classes" excluding="**/*.java"/>
<classpathentry kind="src" path="src/main/java" including="**/*.java"/>
<classpathentry kind="src" path="target/jspc" including="**/*.java"/>
<classpathentry kind="src" path="target/generated-sources" including="**/*.java"/>
<classpathentry kind="src" path="src/main/resources" excluding="**/*.java"/>
<classpathentry kind="src" path="src/main" including="webapps/**/*.gif|webapps/**/*.css|webapps/**/*.html|webapps/**/*.xml" excluding="**/*.java"/>
... snip ...
I think the latter "src/main" declaration is clobbering the prior "src/main/java" declaration.
Changing the POM to read:
<resource>
<directory>src/main/webapps</directory>
<includes>
<include>**/*.gif</include>
<include>**/*.css</include>
<include>**/*.html</include>
<include>**/*.xml</include>
</includes>
</resource>
Fixes the issue.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837991#action_12837991 ]
stack commented on HBASE-2254:
------------------------------
Lars, the fellas up on IRC said they needed your v5 applied so I went ahead and did it. If you want to add new stuff, do it here or in a new issue?
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837749#action_12837749 ]
Lars Francke commented on HBASE-2254:
-------------------------------------
No new patch but a few more things I've updated before I forget. Also a few questions
* Updated the assembly descriptor schema version
* The replication contrib wasn't added to the final build (my bad)
* The assembly plugin was complaining about path entries longer than 100 characters. Such entries can only be processed by GNU compatible tar versions. I disabled this warning.
* CHANGES was missing from final .tar file
Questions/Remarks:
* The current Ant and Ivy files should be removed, they won't work without heavy refactoring, anyone who tries will in all probability run into problems
* The stargate lib directory and war file now contains _all_ dependencies (even transitive) instead of only the added dependencies. This adds about 35 MB to the final .tar. I don't know enough about stargate (have never looked at it) to know if this is a good or a bad thing. I'll revisit this later but it would be nice if someone could give a short explanation about what the best behaviour would be
* The .tar file doesn't contain docs, src or webapps directory. There is however a *-source.jar which seems to be complete and the *.jar does contain the webapps stuff. Your decision if you want to include the unpacked versions of this. As to the docs: Javadoc generation seems to be missing, I'll have a look at it
* There are a few deprecation warnings we can't/won't do anything about, mainly in the generated thrift classes and in the mapred package, I'll see if I can exclude those warnings but I don't think that's possible
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837597#action_12837597 ]
Lars Francke commented on HBASE-2254:
-------------------------------------
The scopes were removed from all those dependencies that are common to all the modules. Those definitions are now in the dependencyManagement section of the main pom. These definitions are inherited so there is no need to repeat them. I tried it and it did seem to work the way I intended it but I'll have a second look tomorrow if I missed something.
The changes to the surefire plugin are an easy fix. I can incorporate them into the patch.
I already had a look at dependency:tree and dependency:analyze and will continue to improve the POMs tomorrow (if no one does it before then). At the moment my target is to get a tar that runs on my server though ;-)
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "Paul Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837593#action_12837593 ]
Paul Smith commented on HBASE-2254:
-----------------------------------
awesome work.
in core/pom.xml the test scope was removed for hadoop-mapred-test, not sure I understand why that's removed, that'll mean that hbase-core will always need hadoop-mapred-test classes?
same goes for the other hadoop-*-test ones.. ?
One other suggestion is to have the maven-surefire-plugin default to forkMode:always, and perhaps up the RAM a bit given what we've seen.
I like the includeBaseDirectory change, in fact I think that's the default anyway, but I was matching the original hbase jar output, but I +1 on your change personally.
Once we're happy with the general structure of the tar ball, I think going through and defining the transitive dependency scopes (optional etc) will help prune down the overall size. Based on your experience, you'll know whether a dependency declared downstream is needed anyway, so just excluding them may be enough.
someone should go through the output of 'mvn dependency:tree' and tick or cross off what is not needed.
thanks, awesome work.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837873#action_12837873 ]
stack commented on HBASE-2254:
------------------------------
Great stuff Lars (and Patrick).
I agree ant and ivy stuff should be removed. We should do that in separate issue and it'd be great if stargate didn't duplicate jars. I'll wait on Paul's review before committing. He might have stuff to add.
> Improvements to the Maven POMs
> ------------------------------
>
> Key: HBASE-2254
> URL: https://issues.apache.org/jira/browse/HBASE-2254
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.21.0
> Reporter: Lars Francke
> Priority: Minor
> Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and defined the plugin versions
> * I've fixed a type in the compiler plugin showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.