[jira] [Commented] (KYLIN-999) License check and cleanup for release

["Shaofeng SHI (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936514#comment-14936514 ] 

Shaofeng SHI commented on KYLIN-999:
------------------------------------

Hi Justin, thanks for pointing this out to us! You're correct that we shouldn't add Apache header to those files which is MIT or other license; That was our mistake; 

Actually the "website" module is to track the web content of kylin project's home page (https://kylin.incubator.apache.org/), it is not source code and will never be included in Kylin's releases; We have excluded those files from the RAT check, and I just corrected the unnecessary Apache headers in the files that you mentioned, like  animate.css, bootstrap, font awsome, etc (see commit https://github.com/apache/incubator-kylin/commit/7378115eb2e3923b2244df1c7be59c0b7ca87ae6); 

Based on this, the LICENSE will kept as-is because Kylin release doesn't ship Adobe webfont; 
 
Please let me know if you have any suggestion; Thanks very much for your input!

> License check and cleanup for release
> -------------------------------------
>
>                 Key: KYLIN-999
>                 URL: https://issues.apache.org/jira/browse/KYLIN-999
>             Project: Kylin
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: v1.0
>            Reporter: Luke Han
>            Assignee: Luke Han
>             Fix For: v1.1
>
>
> Hi,
> Sorry but it’s -1 (binding), although you have enough +1 to go ahead and make a release.
> This issue that has occurred before [1] and even if the website isn’t included in the release it looks like there may be a still few issues to fix there.
> I checked
> - package contains incubating
> - Signatures good
> - DISCLAIMER exits
> - LICENSE issues (see below)
> - NOTICE fine
> - No unexpected binary files
> - All source file have apache headers
> The file  ./website/assets/css/animate.css has had an Apache header put on it when it is MIT licensed. There are probably other files that are incorrect in this way but I’ve not looked in detail. Perhaps ./website/assets/fonts/helveticaneue-webfont.svg and ./website/assets/fonts/helveticaneue-webfont.css? but that may have a more serious issue.
> The font files ./website/assets/fonts/helveticaneue-webfont.* seem to licensed like so (from the font meta data):
> "Copyright (c) 1988, 1990 Adobe Systems Incorporated.  All Rights Reserved.Helvetica is a registered trademark of Linotype AG and/or its subsidiaries.”
> Other minor LICENSE issues:
> - Missing MIT licensed for animate.css
> - Missing MIT for Bootstrap and normalise.css
> - Missing MIT for jQuery
> - Missing MIT for font awsome
> - Missing SIL for font awsome
> Not required but you may want to add Apache license for the open sans font to LICENSE as it not immediately obvious how that binary file is licensed.
> Thanks,
> Justin
> 1. http://apache.markmail.org/message/z6k3yivyo6xz24by



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)