You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hi...@yahoo.com.INVALID> on 2016/09/13 22:30:54 UTC
GEODE-37 (Hold your checkins in develop)
As part of GEODE-37, I am changing com.gemstone.gemfire package name to org.apache.geode.
Thus I request you to hold your checkins in "develop" for next couple of days. I will update you once I am done with that.
Thanks.HItesh
Re: GEODE-37 (Hold your checkins in develop)
Posted by Anthony Baker <ab...@pivotal.io>.
Yea, the geode-pulse src is still com.vmware.gemfire too.
Anthony
> On Sep 19, 2016, at 1:10 PM, Kirk Lund <kl...@pivotal.io> wrote:
>
> Hitesh and I just noticed some io.pivotal.geode packages in
> geode-spark-connector that probably need to be converted to
> org.apache.geode.
>
> -Kirk
>
>
> On Thu, Sep 15, 2016 at 4:27 PM, Kirk Lund <kl...@pivotal.io> wrote:
>
>> I decided to go ahead and scrub real domains and machine names from
>> LauncherLifecycleCommandsJUnitTest. This way it won't give false positive
>> hits when grepping for gemstone or vmware.
>>
>> Completed:
>>
>> #6) replace real domains and machines with fake names for unit test
>> [commit 8341d7]
>>
>> Thanks,
>> Kirk
>>
>>
>> On Thu, Sep 15, 2016 at 4:10 PM, Anthony Baker <ab...@pivotal.io> wrote:
>>
>>> I found a lot of references to gemstone.com as well. At some point
>>> we’ll need to update and change those url’s.
>>>
>>> Anthony
>>>
>>>
>>>> On Sep 15, 2016, at 4:04 PM, Kirk Lund <kl...@pivotal.io> wrote:
>>>>
>>>> I completed some additional cleanup for GEODE-37:
>>>>
>>>> #1) Update IDE formatters [commit 17a434]
>>>> #3) log4j [commit e13875]
>>>> #5) log4j portion [commit e13875]
>>>> #5) security portion [commit ef39b3]
>>>> #6) weird stuff does not require any change -- this is a UnitTest that
>>> has
>>>> a string host name but does nothing real with it
>>>>
>>>> Questions:
>>>>
>>>> Did we previously move all gemstone.com dtd files to apache.org? Ex:
>>>> http://www.gemstone.com/dtd/authz5_5.dtd -- if so, what's the URL?
>>>>
>>>> Thanks,
>>>> Kirk
>>>>
>>>
>>>
>>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Kirk Lund <kl...@pivotal.io>.
Hitesh and I just noticed some io.pivotal.geode packages in
geode-spark-connector that probably need to be converted to
org.apache.geode.
-Kirk
On Thu, Sep 15, 2016 at 4:27 PM, Kirk Lund <kl...@pivotal.io> wrote:
> I decided to go ahead and scrub real domains and machine names from
> LauncherLifecycleCommandsJUnitTest. This way it won't give false positive
> hits when grepping for gemstone or vmware.
>
> Completed:
>
> #6) replace real domains and machines with fake names for unit test
> [commit 8341d7]
>
> Thanks,
> Kirk
>
>
> On Thu, Sep 15, 2016 at 4:10 PM, Anthony Baker <ab...@pivotal.io> wrote:
>
>> I found a lot of references to gemstone.com as well. At some point
>> we’ll need to update and change those url’s.
>>
>> Anthony
>>
>>
>> > On Sep 15, 2016, at 4:04 PM, Kirk Lund <kl...@pivotal.io> wrote:
>> >
>> > I completed some additional cleanup for GEODE-37:
>> >
>> > #1) Update IDE formatters [commit 17a434]
>> > #3) log4j [commit e13875]
>> > #5) log4j portion [commit e13875]
>> > #5) security portion [commit ef39b3]
>> > #6) weird stuff does not require any change -- this is a UnitTest that
>> has
>> > a string host name but does nothing real with it
>> >
>> > Questions:
>> >
>> > Did we previously move all gemstone.com dtd files to apache.org? Ex:
>> > http://www.gemstone.com/dtd/authz5_5.dtd -- if so, what's the URL?
>> >
>> > Thanks,
>> > Kirk
>> >
>>
>>
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Kirk Lund <kl...@pivotal.io>.
I decided to go ahead and scrub real domains and machine names from
LauncherLifecycleCommandsJUnitTest. This way it won't give false positive
hits when grepping for gemstone or vmware.
Completed:
#6) replace real domains and machines with fake names for unit test
[commit 8341d7]
Thanks,
Kirk
On Thu, Sep 15, 2016 at 4:10 PM, Anthony Baker <ab...@pivotal.io> wrote:
> I found a lot of references to gemstone.com as well. At some point we’ll
> need to update and change those url’s.
>
> Anthony
>
>
> > On Sep 15, 2016, at 4:04 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> > I completed some additional cleanup for GEODE-37:
> >
> > #1) Update IDE formatters [commit 17a434]
> > #3) log4j [commit e13875]
> > #5) log4j portion [commit e13875]
> > #5) security portion [commit ef39b3]
> > #6) weird stuff does not require any change -- this is a UnitTest that
> has
> > a string host name but does nothing real with it
> >
> > Questions:
> >
> > Did we previously move all gemstone.com dtd files to apache.org? Ex:
> > http://www.gemstone.com/dtd/authz5_5.dtd -- if so, what's the URL?
> >
> > Thanks,
> > Kirk
> >
>
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Anthony Baker <ab...@pivotal.io>.
I found a lot of references to gemstone.com as well. At some point we’ll need to update and change those url’s.
Anthony
> On Sep 15, 2016, at 4:04 PM, Kirk Lund <kl...@pivotal.io> wrote:
>
> I completed some additional cleanup for GEODE-37:
>
> #1) Update IDE formatters [commit 17a434]
> #3) log4j [commit e13875]
> #5) log4j portion [commit e13875]
> #5) security portion [commit ef39b3]
> #6) weird stuff does not require any change -- this is a UnitTest that has
> a string host name but does nothing real with it
>
> Questions:
>
> Did we previously move all gemstone.com dtd files to apache.org? Ex:
> http://www.gemstone.com/dtd/authz5_5.dtd -- if so, what's the URL?
>
> Thanks,
> Kirk
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Kirk Lund <kl...@pivotal.io>.
I completed some additional cleanup for GEODE-37:
#1) Update IDE formatters [commit 17a434]
#3) log4j [commit e13875]
#5) log4j portion [commit e13875]
#5) security portion [commit ef39b3]
#6) weird stuff does not require any change -- this is a UnitTest that has
a string host name but does nothing real with it
Questions:
Did we previously move all gemstone.com dtd files to apache.org? Ex:
http://www.gemstone.com/dtd/authz5_5.dtd -- if so, what's the URL?
Thanks,
Kirk
On Thu, Sep 15, 2016 at 12:38 PM, Kirk Lund <kl...@pivotal.io> wrote:
> Unless someone objects or really wants to work these, I will take these:
>
> 1) Update IDE formatters
> 3) log4j
> partial 5) only the log4j and security pieces
> 6) weird stuff
>
> -Kirk
>
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Kirk Lund <kl...@pivotal.io>.
Unless someone objects or really wants to work these, I will take these:
1) Update IDE formatters
3) log4j
partial 5) only the log4j and security pieces
6) weird stuff
-Kirk
Re: GEODE-37 (Hold your checkins in develop)
Posted by Anthony Baker <ab...@pivotal.io>.
Here are a few more changes that are needed:
1) Update IDE formatters:
./etc/eclipseOrganizeImports.importorder
./etc/intellijIdeaCodeStyle.xml
2) Javadocs
geode-core/src/main/java/org/apache/geode/distributed/internal/package.html
geode-core/src/main/java/org/apache/geode/internal/cache/properties.html
geode-core/src/main/java/org/apache/geode/internal/cache/DistPeerTXStateStub.java
geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateOnCoordinator.java
3) log4j
geode-core/src/main/resources/log4j2-cli.xml
geode-core/src/main/resources/log4j2.xml
geode-core/src/main/resources/org/apache/geode/internal/logging/log4j/log4j2-legacy.xml
4) config
geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-8.1.xsd
geode-core/src/main/resources/org/apache/geode/admin/doc-files/*.dtd // are these important?
geode-site/content/schema/cache/cache-1.0.xsd
5) tests
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt
**/cachejta.xml
geode-core/src/test/resources/org/apache/geode/security/templates/*.dtd
geode-core/src/test/resources/org/apache/geode/internal/logging/log4j/custom/log4j2-custom.xml
geode-core/src/test/resources/org/apache/geode/test/golden/log4j2-test.xml
geode-core/src/test/resources/org/apache/geode/test/golden/log4j2-test.xml
6) weird stuff
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java uses an internal hostname?
Anthony
> On Sep 14, 2016, at 7:10 PM, Hitesh Khamesra <hi...@yahoo.com.INVALID> wrote:
>
> Yes, all changes are in "feature/GEODE-37_2" branch. Please let me know if you see any issue with it.
> I need to merge one chenkin which happen in-between.
> One can look history in following way..
> git log --follow ./geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>
> Thanks.Hitesh
>
>
> From: Anthony Baker <ab...@pivotal.io>
> To: dev@geode.incubator.apache.org
> Sent: Wednesday, September 14, 2016 7:02 PM
> Subject: Re: GEODE-37 (Hold your checkins in develop)
>
> Thanks Hitesh! Are your changes available on a feature branch where we could review and comment?
>
> Anthony
>
>> On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra <hi...@yahoo.com.INVALID> wrote:
>>
>> As part of GEODE-37, I am changing com.gemstone.gemfire package name to org.apache.geode.
>> Thus I request you to hold your checkins in "develop" for next couple of days. I will update you once I am done with that.
>> Thanks.HItesh
>>
>
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Hitesh Khamesra <hi...@yahoo.com.INVALID>.
Yes, all changes are in "feature/GEODE-37_2" branch. Please let me know if you see any issue with it.
I need to merge one chenkin which happen in-between.
One can look history in following way..
git log --follow ./geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
Thanks.Hitesh
From: Anthony Baker <ab...@pivotal.io>
To: dev@geode.incubator.apache.org
Sent: Wednesday, September 14, 2016 7:02 PM
Subject: Re: GEODE-37 (Hold your checkins in develop)
Thanks Hitesh! Are your changes available on a feature branch where we could review and comment?
Anthony
> On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra <hi...@yahoo.com.INVALID> wrote:
>
> As part of GEODE-37, I am changing com.gemstone.gemfire package name to org.apache.geode.
> Thus I request you to hold your checkins in "develop" for next couple of days. I will update you once I am done with that.
> Thanks.HItesh
>
Re: GEODE-37 (Hold your checkins in develop)
Posted by Anthony Baker <ab...@pivotal.io>.
Thanks Hitesh! Are your changes available on a feature branch where we could review and comment?
Anthony
> On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra <hi...@yahoo.com.INVALID> wrote:
>
> As part of GEODE-37, I am changing com.gemstone.gemfire package name to org.apache.geode.
> Thus I request you to hold your checkins in "develop" for next couple of days. I will update you once I am done with that.
> Thanks.HItesh
>