You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Robert Houghton <rh...@pivotal.io> on 2019/11/22 19:55:57 UTC
[VOTE] Fix bad-merge of GEODE-7488
I was overzealous in a merge to Geode, and got us into a chicken-and-egg
issue for PRs and reverts. Calling a vote to override the GitHub merge
button restriction via commiter privileges, to merge the fix in
https://github.com/apache/geode/pull/4360
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Kirk Lund <kl...@apache.org>.
+1 adding my vote
On Fri, Nov 22, 2019 at 11:56 AM Robert Houghton <rh...@pivotal.io>
wrote:
> I was overzealous in a merge to Geode, and got us into a chicken-and-egg
> issue for PRs and reverts. Calling a vote to override the GitHub merge
> button restriction via commiter privileges, to merge the fix in
> https://github.com/apache/geode/pull/4360
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Udo Kohlmeyer <ud...@apache.com>.
No brainer vote for me. +1
@Donal, overrides should only EVER be for "break glass emergency".
Anybody who would abuse it for any other reason, should seriously be
considered "enemy-of-the-state".
--Udo
On 11/22/19 11:55 AM, Robert Houghton wrote:
> I was overzealous in a merge to Geode, and got us into a chicken-and-egg
> issue for PRs and reverts. Calling a vote to override the GitHub merge
> button restriction via commiter privileges, to merge the fix in
> https://github.com/apache/geode/pull/4360
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Dan Smith <ds...@pivotal.io>.
+1 Go for it.
-Dan
On Fri, Nov 22, 2019 at 12:07 PM Owen Nichols <on...@pivotal.io> wrote:
> It would set a bad precedent to circumvent without due process a decision
> that was agreed by the Geode community <
> https://lists.apache.org/thread.html/1ba19d9aeb206148c922afdd182ba322d6f128bbb83983f2f72a108e@%3Cdev.geode.apache.org%3E
> >.
>
> > On Nov 22, 2019, at 12:00 PM, Anthony Baker <ab...@pivotal.io> wrote:
> >
> > Clearly the right thing to do is fix it. VOTE not needed IMO.
> >
> > Anthony
> >
> >
> >> On Nov 22, 2019, at 11:55 AM, Robert Houghton <rh...@pivotal.io>
> wrote:
> >>
> >> I was overzealous in a merge to Geode, and got us into a chicken-and-egg
> >> issue for PRs and reverts. Calling a vote to override the GitHub merge
> >> button restriction via commiter privileges, to merge the fix in
> >> https://github.com/apache/geode/pull/4360
> >
>
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Owen Nichols <on...@pivotal.io>.
It would set a bad precedent to circumvent without due process a decision that was agreed by the Geode community <https://lists.apache.org/thread.html/1ba19d9aeb206148c922afdd182ba322d6f128bbb83983f2f72a108e@%3Cdev.geode.apache.org%3E>.
> On Nov 22, 2019, at 12:00 PM, Anthony Baker <ab...@pivotal.io> wrote:
>
> Clearly the right thing to do is fix it. VOTE not needed IMO.
>
> Anthony
>
>
>> On Nov 22, 2019, at 11:55 AM, Robert Houghton <rh...@pivotal.io> wrote:
>>
>> I was overzealous in a merge to Geode, and got us into a chicken-and-egg
>> issue for PRs and reverts. Calling a vote to override the GitHub merge
>> button restriction via commiter privileges, to merge the fix in
>> https://github.com/apache/geode/pull/4360
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Donal Evans <do...@pivotal.io>.
+1
While I'm against overriding PR checks in general, this is clearly a
special case.
On Fri, Nov 22, 2019 at 12:10 PM Nabarun Nag <nn...@apache.org> wrote:
> +1
>
> On Fri, Nov 22, 2019 at 12:00 PM Anthony Baker <ab...@pivotal.io> wrote:
>
> > Clearly the right thing to do is fix it. VOTE not needed IMO.
> >
> > Anthony
> >
> >
> > > On Nov 22, 2019, at 11:55 AM, Robert Houghton <rh...@pivotal.io>
> > wrote:
> > >
> > > I was overzealous in a merge to Geode, and got us into a
> chicken-and-egg
> > > issue for PRs and reverts. Calling a vote to override the GitHub merge
> > > button restriction via commiter privileges, to merge the fix in
> > > https://github.com/apache/geode/pull/4360
> >
> >
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Nabarun Nag <nn...@apache.org>.
+1
On Fri, Nov 22, 2019 at 12:00 PM Anthony Baker <ab...@pivotal.io> wrote:
> Clearly the right thing to do is fix it. VOTE not needed IMO.
>
> Anthony
>
>
> > On Nov 22, 2019, at 11:55 AM, Robert Houghton <rh...@pivotal.io>
> wrote:
> >
> > I was overzealous in a merge to Geode, and got us into a chicken-and-egg
> > issue for PRs and reverts. Calling a vote to override the GitHub merge
> > button restriction via commiter privileges, to merge the fix in
> > https://github.com/apache/geode/pull/4360
>
>
Re: [VOTE] Fix bad-merge of GEODE-7488
Posted by Anthony Baker <ab...@pivotal.io>.
Clearly the right thing to do is fix it. VOTE not needed IMO.
Anthony
> On Nov 22, 2019, at 11:55 AM, Robert Houghton <rh...@pivotal.io> wrote:
>
> I was overzealous in a merge to Geode, and got us into a chicken-and-egg
> issue for PRs and reverts. Calling a vote to override the GitHub merge
> button restriction via commiter privileges, to merge the fix in
> https://github.com/apache/geode/pull/4360