You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jian Qiu <qi...@cn.ibm.com> on 2016/04/09 09:14:46 UTC
Re: Review Request 43935: Allow setting role in mesos-execute.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
-----------------------------------------------------------
(Updated 四月 9, 2016, 7:14 a.m.)
Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
Changes
-------
rebase
Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744
Repository: mesos
Description
-------
Allow setting role in mesos-execute.
Diffs (updated)
-----
src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87
Diff: https://reviews.apache.org/r/43935/diff/
Testing
-------
make & make check
start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos
start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --resources="cpus:1;mem:512"
running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512"
running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512"
Thanks,
Jian Qiu
Re: Review Request 43935: Allow setting role in mesos-execute.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review128009
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 9, 2016, 7:14 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> -----------------------------------------------------------
>
> (Updated April 9, 2016, 7:14 a.m.)
>
>
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
>
>
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow setting role in mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87
>
> Diff: https://reviews.apache.org/r/43935/diff/
>
>
> Testing
> -------
>
> make & make check
>
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
>
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
>
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --resources="cpus:1;mem:512"
>
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512"
>
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512"
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 43935: Allow setting role in mesos-execute.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review127979
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43935]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 9, 2016, 7:14 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> -----------------------------------------------------------
>
> (Updated April 9, 2016, 7:14 a.m.)
>
>
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
>
>
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow setting role in mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87
>
> Diff: https://reviews.apache.org/r/43935/diff/
>
>
> Testing
> -------
>
> make & make check
>
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
>
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
>
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --resources="cpus:1;mem:512"
>
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512"
>
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512"
>
>
> Thanks,
>
> Jian Qiu
>
>