You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Juan Pablo Santos RodrÃguez (JIRA)" <ji...@apache.org> on 2014/04/19 14:08:15 UTC
[jira] [Commented] (JSPWIKI-814) VersioningFileProvider does
migrate original page properties
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974838#comment-13974838 ]
Juan Pablo Santos RodrÃguez commented on JSPWIKI-814:
-----------------------------------------------------
Hi Brian,
after aplying the three patches on a clean env, three tests are failing:
- testMigrationMultiChangesHistory
- testMigrationMultiChangesNoCache
- testMigrationMultiChangesNoCache
the culprit seems to be in the TestEngine patch: it adds {{page.setAuthor(Users.JANNE);}} to the saveText method, but it seems it should be on the {{TestEngine#saveTextAsJanne()}} method. After making this change, all tests run successfully. Would you mind confirming this behaviour before adding it into trunk?
thx+br,
> VersioningFileProvider does migrate original page properties
> ------------------------------------------------------------
>
> Key: JSPWIKI-814
> URL: https://issues.apache.org/jira/browse/JSPWIKI-814
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.10
> Environment: ubuntu linux and openjdk 1.7.0_25. mvn test.
> Reporter: Brian Burch
> Priority: Minor
> Labels: features
> Fix For: FutureVersion
>
> Attachments: JSPWIKI-814-VersioningFileProviderTest-10140303.patch, JSPWIKI-814-patchNew-TestEngine, JSPWIKI-814-patchNew-VersioningFileProvider
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The default FileSystemProvider maintains two files for each wiki page. e.g. MyPage.txt has an associated MyPage.properties, which records the timestanp and author of the last change to that page.
> VersioningFileProvider contains logic to "migrate" a wiki page created by FileSystemProvider when it is next updated. This migration works properly for MyPage.txt, but the new change history for the page in the OLD/ subdirectory starts at version 2 and ignores the history available in MyPage.properties.
> Also, the original MyPage.properties remains in "suspended animation", even though the migrated page history has been created.
--
This message was sent by Atlassian JIRA
(v6.2#6252)