[GitHub] nifi pull request #1636: NIFI-1833 - Azure Storage processors

[jtstorck <gi...@git.apache.org>]

Github user jtstorck commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1636#discussion_r109723701
  
    --- Diff: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureBlobProcessor.java ---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.azure;
    +
    +import java.net.URISyntaxException;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Objects;
    +
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.processor.util.StandardValidators;
    +
    +import com.microsoft.azure.storage.StorageException;
    +import com.microsoft.azure.storage.blob.CloudBlob;
    +import com.microsoft.azure.storage.blob.CloudBlobContainer;
    +
    +public abstract class AbstractAzureBlobProcessor extends AbstractAzureProcessor {
    +
    +    public static final PropertyDescriptor BLOB = new PropertyDescriptor.Builder().name("Blob").description("The filename of the blob").addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .expressionLanguageSupported(true).required(true).defaultValue("${azure.blobname}").build();
    +
    +    public static final PropertyDescriptor BLOB_TYPE = new PropertyDescriptor.Builder()
    +            .name("Blob type")
    +            .description("Blobs can be block type of page type")
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .allowableValues(AzureConstants.BLOCK, AzureConstants.PAGE)
    +            .defaultValue(AzureConstants.BLOCK.getValue())
    +            .required(true).build();
    +
    +    public static final List<PropertyDescriptor> properties = Collections
    +            .unmodifiableList(Arrays.asList(AzureConstants.ACCOUNT_NAME, AzureConstants.ACCOUNT_KEY, AzureConstants.CONTAINER, BLOB, BLOB_TYPE));
    +
    +    @Override
    +    protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
    +        return properties;
    +    }
    +
    +    /**
    +     * Get a reference to a blob based on the type.
    +     *
    +     */
    +    protected CloudBlob getBlob(CloudBlobContainer container, String blobType, String blobPath) throws URISyntaxException, StorageException {
    --- End diff --
    
    Should blobType be checked more explicitly here?  If blobType doesn't match the case of "Block", won't this end up returning a page blob?  If an invalid blobType is passed in, is it appropriate that a page blob is returned, or should a ProcessorException be thrown?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---