You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/27 03:25:53 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #6034: [INLONG-6033][Agent] Support for hidden directories
GanfengTan opened a new pull request, #6034:
URL: https://github.com/apache/inlong/pull/6034
Support for hidden directories.
For example:/tmp/test/**/test.xml
- Fixes #6033
### Motivation
add util
### Modifications
No message
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6034: [INLONG-6033][Agent] Support for hidden directories
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6034:
URL: https://github.com/apache/inlong/pull/6034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6034: [INLONG-6033][Agent] Support for hidden directories
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6034:
URL: https://github.com/apache/inlong/pull/6034#discussion_r980706856
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/utils/AgentUtils.java:
##########
@@ -281,6 +282,13 @@ public static String formatCurrentTimeWithoutOffset(String formatter) {
* @return true if all match
*/
public static boolean regexMatch(String pathStr, String patternStr) {
+ // /tmp/dir1/**/test.xml
+ if (patternStr.contains(HIDDEN_DIR)) {
+ if (matchHiddenDir(pathStr, patternStr)) {
Review Comment:
'if' statement can be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #6034: [INLONG-6033][Agent] Support for hidden directories
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #6034:
URL: https://github.com/apache/inlong/pull/6034#discussion_r980812326
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/utils/AgentUtils.java:
##########
@@ -281,6 +282,13 @@ public static String formatCurrentTimeWithoutOffset(String formatter) {
* @return true if all match
*/
public static boolean regexMatch(String pathStr, String patternStr) {
+ // /tmp/dir1/**/test.xml
+ if (patternStr.contains(HIDDEN_DIR)) {
+ if (matchHiddenDir(pathStr, patternStr)) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org