[GitHub] [pulsar] zzzming opened a new pull request #14112: correct uploadBuiltinSinksSources in the functions_worker.yml

[GitBox <gi...@apache.org>]

zzzming opened a new pull request #14112:
URL: https://github.com/apache/pulsar/pull/14112


   # Fix
   
   The current `uploadBuiltinSinksSources` config is placed in the wrong placed. It is part of WorkerConfig.java. It should be part of first level key in functions_worker.yml.
   
   The current config results in this exception and the function in Kubernetes Runtime failed to start 
   ````
   Exception in thread "main" com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "uploadBuiltinSinksSources" (class org.apache.pulsar.functions.worker.WorkerConfig$KubernetesContainerFactory), not marked as ignorable (27 known properties: "submittingInsidePod", "pulsarDockerImageName", "percentMemoryPadding", "pulsarRootDir", "customLabels", "changeConfigMapNamespace", "imagePullPolicy", "pulsarServiceUrl", "cpuOverCommitRatio", "installUserCodeDependencies", "jobNamespace", "memoryOverCommitRatio", "metricsPort", "gracePeriodSeconds", "narExtractionDirectory", "jobName", "pythonExtraDependencyRepository", "changeConfigMap", "functionDockerImages", "pythonDependencyRepository", "configAdminCLI", "extraFunctionDependenciesDir", "pulsarAdminUrl", "k8Uri", "expectedMetricsCollectionInterval", "functionInstanceClassPath", "grpcPort"])
    at [Source: (File); line: 36, column: 35] (through reference chain: org.apache.pulsar.functions.worker.WorkerConfig["kubernetesContainerFactory"]->org.apache.pulsar.functions.worker.WorkerConfig$KubernetesContainerFactory["uploadBuiltinSinksSources"])
   ```
   
   ### Modifications
   
   The fix is to move the config in the first level config.
   
   ### Verifying this change
   
   Function worker in kubernetes is able to start.
   
   
   This change is a trivial rework
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
     
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14112: correct uploadBuiltinSinksSources in the functions_worker.yml

[GitBox <gi...@apache.org>]

codelipenghui merged pull request #14112:
URL: https://github.com/apache/pulsar/pull/14112


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org