[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5745: Allow serving of offline segments immediately/inclusively.

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5745:
URL: https://github.com/apache/incubator-pinot/pull/5745#discussion_r460169975



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -235,7 +234,7 @@ public void start()
     FunctionRegistry.init();
     _brokerRequestHandler =
         new SingleConnectionBrokerRequestHandler(_brokerConf, _routingManager, _accessControlFactory, queryQuotaManager,
-            _brokerMetrics, _propertyStore);
+            _brokerMetrics, new TableCache(_propertyStore));

Review comment:
       Don't we pick up all table configs to get query quotas (at least, the tables managed by the current broker).
   In any case, we should restrict it to tables managed by this broker, and not all tables on the cluster.
   With shared brokers in clusters that still does not help, so we need to find a better solution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org