You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/08 17:50:54 UTC

[GitHub] ashb commented on a change in pull request #4673: [AIRFLOW-3851] ExternalTasksensor not check existence in later poke

ashb commented on a change in pull request #4673: [AIRFLOW-3851] ExternalTasksensor not check existence in later poke
URL: https://github.com/apache/airflow/pull/4673#discussion_r255172996
 
 

 ##########
 File path: airflow/sensors/external_task_sensor.py
 ##########
 @@ -117,7 +119,9 @@ def poke(self, context, session=None):
         DM = DagModel
         TI = TaskInstance
         DR = DagRun
-        if self.check_existence:
+
+        # we only do the check for 1st time, no need for subsequent poke
+        if self.check_existence and not self.has_check_existence:
 
 Review comment:
   Nothing wrong with this, but with the rescheduling of sensors this won't be persisted :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services