[GitHub] [incubator-doris] imay commented on a change in pull request #3044: Write delete predicate into RowsetMeta upon upgrade from Doris-0.10 to Doris-0.11

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3044: Write delete predicate into RowsetMeta upon upgrade from Doris-0.10 to Doris-0.11
URL: https://github.com/apache/incubator-doris/pull/3044#discussion_r388688841
 
 

 ##########
 File path: be/src/olap/olap_snapshot_converter.h
 ##########
 @@ -47,7 +47,7 @@ class OlapSnapshotConverter {
     // convert olap header to tablet meta pb, convert delta to rowsetmetapb
     // pending delta is not in tablet meta any more, so that convert pending delta to rowset and add it to pending rowsets
     // as a return value
-    OLAPStatus to_tablet_meta_pb(const OLAPHeaderMessage& olap_header, TabletMetaPB* tablet_meta_pb, 
+    OLAPStatus to_tablet_meta_pb(OLAPHeaderMessage* olap_header, TabletMetaPB* tablet_meta_pb,
 
 Review comment:
   Originally, this function only converts the header to meta.
   Can you implement another function to finish new added operation to make it less complicate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org