You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/22 14:37:55 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3463: ARTEMIS-3093 Ordering on multiple consuemrs and Core with Rollback
clebertsuconic opened a new pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783529636
I am fixing and running tests... please, do not merge this yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783589555
We did, yeah...
What I'm doing now, is I'm always using addSorted on close / rollback.
While scheduling will still use addHead... so we won't need scheduling argument on addSorted...
I did some cleanup then on the API around it.
Back then I thought we should have kept core as it was. but I see this change on core would be better as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783662998
Ah ok. So basically youre no longer making distinction between amqp and other clients and applying the same logic regardless. Gotcha nice. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783589555
@michaelandrepearce We did, yeah...
What I'm doing now, is I'm always using addSorted on close / rollback.
While scheduling will still use addHead... so we won't need scheduling argument on addSorted...
I did some cleanup then on the API around it.
Back then I thought we should have kept core as it was. but I see this change on core would be better as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783575301
Im getting a bit of de ja vu here. Didnt alot of these changes being removed you added for something similar with ordering before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783637057
fixed it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783575301
Im getting a bit of de ja vu here. Didnt alot of these changes being removed you/we added for something similar with ordering before on amqp? In Artemis-2458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783672546
I will wait the test results on a 3 hours run I have with the whole test suite before I merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3463: ARTEMIS-3093 Ordering on multiple consumers
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3463:
URL: https://github.com/apache/activemq-artemis/pull/3463#issuecomment-783623800
I will minimize the changes though... I will keep the scheduling for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org