[XL] Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Murtadha Hubail <mh...@apache.org>:

Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha Hubail, Rithwik Koul.

Murtadha Hubail has posted comments on this change by Rithwik Koul. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
......................................................................


Patch Set 59:

(12 comments)

File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/971a46ba_df421b79?usp=email :
PS59, Line 154: plancache
Let's fix this name


File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/8e6b8519_32a3bea1?usp=email :
PS59, Line 155: private CompiledPlan lastCompiledPlan;
why the gap?


File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/PlanCacheApiServlet.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/ace25345_f77b147d?usp=email :
PS59, Line 54: results
🤮


File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/a6d3aa95_02167b9c?usp=email :
PS59, Line 69: plancache
Let's fix this name


File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/747b9cd7_9278938b?usp=email :
PS59, Line 5670: ignoreCache
Should this be just calculated inside resolveQuery..?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/770ecd14_f4318d13?usp=email :
PS59, Line 5682: CacheMissResult
I still don't like this, but you can leave it and maybe refactor it at a later point


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/8dcef0ed_b60b2206?usp=email :
PS59, Line 5734:         warnings.removeIf(preExisting::contains);
You need a comment to "why" you are doing this


File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCache.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/9e618f08_28d03d04?usp=email :
PS59, Line 24: IQueryPlanCache
Add java docs


File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCacheKey.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/3d667312_ce10d446?usp=email :
PS59, Line 28: IQueryPlanCacheKey
Add java docs. Also, the methods aren't using java convention


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/2c745031_e40d923a?usp=email :
PS59, Line 34: optimize
I don't think you need those getters here


File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryPlanCacheValue.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/185698b0_528b9cdd?usp=email :
PS59, Line 31: IQueryPlanCacheValue
Add java docs


File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/6a798015_704e75eb?usp=email :
PS59, Line 76: // TODO (GLENN): base default capacity off of available memory?
Remove this



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I116e5fa9d16e5c4a5cc6dfbdf8db230221086a9d
Gerrit-Change-Number: 21328
Gerrit-PatchSet: 59
Gerrit-Owner: Rithwik Koul <ri...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Rithwik Koul <ri...@couchbase.com>
Gerrit-CC: Ian Maxon <im...@apache.org>
Gerrit-CC: Murtadha Hubail <mh...@apache.org>
Gerrit-Attention: Ian Maxon <im...@apache.org>
Gerrit-Attention: Rithwik Koul <ri...@couchbase.com>
Gerrit-Attention: Ali Alsuliman <al...@couchbase.com>
Gerrit-Attention: Murtadha Hubail
Gerrit-Comment-Date: Thu, 02 Jul 2026 14:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No