[jira] [Work logged] (ARTEMIS-2420) Reimplementation of AMQ5 dead letter strategy queuePrefix

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2420?focusedWorklogId=330090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330090 ]

ASF GitHub Bot logged work on ARTEMIS-2420:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Oct/19 19:44
            Start Date: 17/Oct/19 19:44
    Worklog Time Spent: 10m 
      Work Description: rcsilva83 commented on issue #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
URL: https://github.com/apache/activemq-artemis/pull/2760#issuecomment-543332194
 
 
   Please, support suffix on "dead-letter-address-auto-create" element too. We prefer "Queue.Name.DLQ" so DLQ queues stay close to the original ones in alphabetical order. This is how our current ActiveMQ is configured.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 330090)
    Remaining Estimate: 0h  (was: 10m)
            Time Spent: 12h  (was: 11h 50m)

> Reimplementation of AMQ5 dead letter strategy queuePrefix
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-2420
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2420
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Piotr Klimczak
>            Priority: Major
>   Original Estimate: 12h
>          Time Spent: 12h
>  Remaining Estimate: 0h
>
> ActiveMQ Classic supports DLQ prefixes for dynamically created destinations.
> This causes regression when switching from AMQ5 to AMQ Artemis, therefore it should be reimplemented.
> *Detailed requirements*
> *Configuration*
>  # Prefix for dead-letter-address-auto-create is mandatory, while the tag itself is optional - DONE
>  # All attributes for dead-letter-address-auto-create are optional, in which case values will be taken from origin queue  - DONE
>  ** routing type for DLQ
>  ** temporary
>  ** durable can be null
>  # DLA settings can be defined with address-settings with wildcard match - DONE
>  # Should throw error if both DLA and auto-create DLA are defined for same AS - *TODO*
> Example
> {code:xml}
>      <address-setting match="#">
>         <dead-letter-address-auto-create prefix="DLA.">
>            <routing-type>MULTICAST</routing-type>
>            <durable>true</durable>
>            <temporary>false</temporary>
>         </dead-letter-address-auto-create>
>      </address-setting>
>      <address-setting match="DLA.#">
>          <!-- DLA config goes here, as for standard addresses -->
>      </address-setting>
> {code}
> Questions:
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if both dead letter address is set and prefix?
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Is there auto clean up, so the auto created dead letter addresses are removed when the original address is removed, in cases of auto creation.
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Also would it be possible to configure a spefiic queue to goto a specific address, taking precedence over the default prefix when set.
>  ** This is how it should work now- *TODO* test coverage
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]:I dea around security and address creation restrictions, could that both the address and queue settings are checked both for the new address/queue and the dead letter, before it is created. Thus meaning that either both create (because permission and settings allow) or both wouldnt. Thus avoiding the situation of one being created without the other
>  ** Not sure if I understand above- *TODO* get clarification
> *Message delivery to DLQ*
>  # Delivery to dynamic DLQ only happens for messages failed by a consumer - DONE
>  # Delivery to dynamic addresses should happen using FQQN address, regardless of routing - DONE 
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: The same should be made for expiryQueues with all the same rules and logic - DONE
> Questions:
>  # Should dynamic DLQ creation also work for messages delivered to an address with no queues?
> *Security*
>  # TODO Consolidate security requirements from original PR: [https://github.com/apache/activemq-artemis/pull/2747]
>  
> Questions:
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if queue/address is allowed to be created due security settings, but the user able to do that is unable to create the dead letter address? Do both fail? Does one part succeed but the dla fails? And then what occurs?
>  # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs when security settings come into play? How does it fail if you have ability to create address but not dla? Do both fail?
>  
> Links to all conversations:
> * [https://github.com/apache/activemq-artemis/pull/2760]
> * [https://github.com/clebertsuconic/activemq-artemis/pull/29]
> * [https://github.com/apache/activemq-artemis/pull/2747]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)