You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/25 19:38:04 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
MaxGekk opened a new pull request #29237:
URL: https://github.com/apache/spark/pull/29237
### What changes were proposed in this pull request?
Override the default implementation of `JdbcDialect.renameTable()`:
```scala
s"ALTER TABLE $oldTable RENAME TO $newTable"
```
in the following JDBC dialects according to official documentation:
- DB2
- Derby
- MS SQL Server
- Teradata
Other dialects follow the default implementation:
- MySQL: https://dev.mysql.com/doc/refman/8.0/en/alter-table.html
- Oracle: https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877
- PostgreSQL: https://www.postgresql.org/docs/12/sql-altertable.html
### Why are the changes needed?
To have correct implementation of table renaming for all supported JDBC dialects.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663917793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-665012763
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663893533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-664183709
@cloud-fan @HyukjinKwon Could you take a look at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663893533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663893410
**[Test build #126553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126553/testReport)** for PR 29237 at commit [`1196eff`](https://github.com/apache/spark/commit/1196eff514479b97648f6ab991cc15862cbee52e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663893410
**[Test build #126553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126553/testReport)** for PR 29237 at commit [`1196eff`](https://github.com/apache/spark/commit/1196eff514479b97648f6ab991cc15862cbee52e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663917688
**[Test build #126553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126553/testReport)** for PR 29237 at commit [`1196eff`](https://github.com/apache/spark/commit/1196eff514479b97648f6ab991cc15862cbee52e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29237:
URL: https://github.com/apache/spark/pull/29237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29237: [SPARK-32382][SQL] Override table renaming in JDBC dialects
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29237:
URL: https://github.com/apache/spark/pull/29237#issuecomment-663917793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org