You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Jean-Baptiste Onofré (Jira)" <ji...@apache.org> on 2022/04/11 11:31:00 UTC

[jira] [Updated] (AMQ-8583) Move class ResponseHandler into package protocol

     [ https://issues.apache.org/jira/browse/AMQ-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré updated AMQ-8583:
--------------------------------------
    Fix Version/s: 5.17.1
                   5.18.0
                       (was: 5.17.0)

> Move class ResponseHandler into package protocol
> ------------------------------------------------
>
>                 Key: AMQ-8583
>                 URL: https://issues.apache.org/jira/browse/AMQ-8583
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.17.0
>            Reporter: Fanyi
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 5.17.1, 5.18.0
>
>         Attachments: Activemq-ResponseHandler-java.png
>
>
> *Issue Description*
>  
> Package *_org.apache.activemq.transport.amqp_* is a promiscuous package, and groups together miscellaneous functionalities that might be useful to different subsystems. This means the cohesion between classes in the package is low. However, since the project has grown larger, this package structure is becoming increasingly hard to navigate. We found that Class *_ResponseHandler_* is not used by classes in their package {*}_org.apache.activemq.transport.amqp_{*}{_}.{_} Moreover, there are a lot of dependencies between class *_ResponseHandler_* and classes in the package {*}_org.apache.activemq.transport.amqp.protocol_{*}.
> Location: The source file can be found at path File /activemq-amqp/src/main/java/org/apache/activemq/transport/amqp/ResponseHandler.java
> *Refactoring suggestions*
>  
> To avoid making *_org.apache.activemq.transport.amqp_* too big and unmanageable, we suggest to move class *_ResponseHandler_* into package \{_}*org.apache.activemq.transport.amqp.protocol*{_}{*}.{*}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)