You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/31 08:20:33 UTC

[GitHub] [apisix-ingress-controller] lingsamuel commented on issue #1058: proposal: restructure `pkg/ingress`

lingsamuel commented on issue #1058:
URL: https://github.com/apache/apisix-ingress-controller/issues/1058#issuecomment-1141815142

   Perhaps we could create an interface called "(Feature)Provider". The provider holds several small controllers and associated clientet/listers/informers.
   
   Also, we should separate the translators and only make the Kubernetes translator publicly accessible, since any other translator could potentially rely on it.
   APISIX Ingress and any other CRD translators should be private.
   
   
   - RootController
     - KubernetesProvider (public)
       - Controllers: secret, service, pod, endpoint...
       - clientset/listers/informers (public)
       - KubernetesTranslator (public)
     - ApisixIngressProvider
       - Controllers: APISIX Ingress CRDs
       - clientset/listers/informers
       - ApisixIngressTranslator
     - GatewayProvider
       - Controllers: Gateway CRDs
       - clientset/listers/informers
       - GatewayTranslator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org