You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/28 02:25:54 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #15: docs: add templates
spacewander opened a new pull request #15:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #15: docs: add templates
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #15:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/15#issuecomment-869287933
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3babba0) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/a6957f80be46361fce7d25a48dc88c448f1e3ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6957f8) will **decrease** coverage by `2.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
- Coverage 81.31% 78.85% -2.47%
==========================================
Files 9 9
Lines 487 487
==========================================
- Hits 396 384 -12
- Misses 71 82 +11
- Partials 20 21 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <0.00%> (-10.72%)` | :arrow_down: |
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6957f8...3babba0](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #15: docs: add templates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #15:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/15#issuecomment-869287933
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6614d99) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/a6957f80be46361fce7d25a48dc88c448f1e3ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6957f8) will **decrease** coverage by `2.46%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6614d99 differs from pull request most recent head 16134fd. Consider uploading reports for the commit 16134fd to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
- Coverage 81.31% 78.85% -2.47%
==========================================
Files 9 9
Lines 487 487
==========================================
- Hits 396 384 -12
- Misses 71 82 +11
- Partials 20 21 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `35.38% <0.00%> (ø)` | |
| [cmd/go-runner/plugins/say.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL3NheS5nbw==) | `71.42% <0.00%> (ø)` | |
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <ø> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `76.92% <ø> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <ø> (-10.72%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6957f8...16134fd](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/15?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #15: docs: add templates
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #15:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Yiyiyimu commented on a change in pull request #15: docs: add templates
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #15:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/15#discussion_r659428731
##########
File path: .github/ISSUE_TEMPLATE/bug-report.md
##########
@@ -0,0 +1,25 @@
+---
+name: Bug report template
+about: Please use this template for reporting suspected bugs.
+title: 'bug: '
+labels: ''
+assignees: ''
+
+---
+
+### Issue description
+
+### Environment
+
+* APISIX Go Plugin Runner's version:
Review comment:
I guess `APISIX version` could have something to do with bugs in the future, although currently we only got one apisix version support go plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org