[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4984: [KYUUBI #4843] Support multiple kubernetes contexts and namespaces

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4984:
URL: https://github.com/apache/kyuubi/pull/4984#discussion_r1237301122


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -341,6 +341,12 @@ trait ProcBuilder {
 
   def clusterManager(): Option[String] = None
 
+  def kubernetesContext(): Option[String] = None
+
+  def kubernetesNamespace(): Option[String] = None

Review Comment:
   That's too crude, the ProcBuilder's API should be generic, otherwise as time going, lots of `kubernetesXYZs` methods will be added in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org