You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 08:47:52 UTC
[GitHub] [flink-docker] zentol opened a new pull request #19: [FLINK-17164] Add job-cluster support
zentol opened a new pull request #19:
URL: https://github.com/apache/flink-docker/pull/19
Adds support for job-clusters.
This PR is also relevant for 1.10, but the commits would be identical.
A job-cluster can be started by passing `standalone-job` to `docker-entrypoint.sh`. User artifacts (i.e., the job jar to run) can be passed via the `USER_ARTIFACTS` environment variable as a list of files/directories, separated with semi-colons (;). This will usually point to some mounted volume.
The script then copies all files into the `usrlib` directory of the distribution.
The vast majority of this PR is concerned with testing. Since a job-cluster cannot be started without a job to run I added a maven project containing a trivial streaming job that runs infinitely.
The jar is built on CI before the tests are run and provided to the jobmanager as described above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] zentol commented on pull request #19: [FLINK-17164] Add job-cluster support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19:
URL: https://github.com/apache/flink-docker/pull/19#issuecomment-621740477
Have to sort out some travis dependencies first (java+maven)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] zentol commented on a change in pull request #19: [FLINK-17164] Add job-cluster support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19:
URL: https://github.com/apache/flink-docker/pull/19#discussion_r417854374
##########
File path: docker-entrypoint.sh
##########
@@ -56,6 +58,27 @@ copy_plugins_if_required() {
done
}
+setup_usrlib() {
+ if [ -z "${USER_ARTIFACTS}" ]; then
+ return 0
Review comment:
one could argue that we should fail here immediately; but I wasn't sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] zentol commented on a change in pull request #19: [FLINK-17164] Add job-cluster support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19:
URL: https://github.com/apache/flink-docker/pull/19#discussion_r417900226
##########
File path: testing/run_travis_tests.sh
##########
@@ -12,6 +12,8 @@ fi
BRANCH="$TRAVIS_BRANCH"
if [ -n "$IS_PULL_REQUEST" ]; then
+ # fetch the branch the PR opened against; we can only generate a diff against master by default
Review comment:
```suggestion
# fetch the branch the PR was opened against; we can only generate a diff against master by default
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org