You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jqin61 (via GitHub)" <gi...@apache.org> on 2024/03/01 17:19:07 UTC
[PR] fix uuid internal representation from str to bytes [iceberg-python]
jqin61 opened a new pull request, #489:
URL: https://github.com/apache/iceberg-python/pull/489
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix uuid partition internal representation from str to bytes [iceberg-python]
Posted by "jqin61 (via GitHub)" <gi...@apache.org>.
jqin61 commented on PR #489:
URL: https://github.com/apache/iceberg-python/pull/489#issuecomment-1976833227
Got it, was under previous discussion impression that we need to use bytes as internal representation of uuid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix uuid partition internal representation from str to bytes [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #489:
URL: https://github.com/apache/iceberg-python/pull/489#issuecomment-1978153309
@jqin61 sorry for the confusion there. We do this for the Literal itself: https://github.com/apache/iceberg-python/blob/9d01b02f14e761b36fe0b88a82274037f7ced5a7/pyiceberg/expressions/literals.py#L600-L610
I don't think the current implementation for the `_to_partition_representation` is correct :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix uuid partition internal representation from str to bytes [iceberg-python]
Posted by "jqin61 (via GitHub)" <gi...@apache.org>.
jqin61 closed pull request #489: Fix uuid partition internal representation from str to bytes
URL: https://github.com/apache/iceberg-python/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org