You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2016/01/16 19:40:21 UTC
[1/2] git commit: updated refs/heads/4.7 to 1b5c645
Repository: cloudstack
Updated Branches:
refs/heads/4.7 55667896d -> 1b5c64578
CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user
Added the parameter listAll=true in case of Internal LB as well as Public LB IP addresses.
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/9014cd31
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/9014cd31
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/9014cd31
Branch: refs/heads/4.7
Commit: 9014cd3101155aed10e4639acc6ece9c768f3929
Parents: d681574
Author: Nitin Kumar Maharana <ni...@gmail.com>
Authored: Fri Dec 18 13:23:50 2015 +0530
Committer: Nitin Kumar Maharana <ni...@gmail.com>
Committed: Wed Jan 6 23:53:07 2016 +0530
----------------------------------------------------------------------
ui/scripts/vpc.js | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/9014cd31/ui/scripts/vpc.js
----------------------------------------------------------------------
diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 4b10d8b..f15cc42 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -748,7 +748,8 @@
$.ajax({
url: createURL('listLoadBalancers'),
data: {
- networkid: args.context.networks[0].id
+ networkid: args.context.networks[0].id,
+ listAll: true
},
success: function(json) {
var items = json.listloadbalancersresponse.loadbalancer;
@@ -1132,7 +1133,8 @@
async: false,
data: {
associatednetworkid: args.context.networks[0].id,
- forloadbalancing: true
+ forloadbalancing: true,
+ listall: true
},
success: function(json) {
var items = json.listpublicipaddressesresponse.publicipaddress;
[2/2] git commit: updated refs/heads/4.7 to 1b5c645
Posted by re...@apache.org.
Merge pull request #1301 from nitin-maharana/CloudStack-Nitin3_4.7
CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin userIssue:
=====
Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI therefore root admin cannot manage those.
Reproducible Steps:
================
Log in as a Domain-Admin account and create a VPC with vpc virtual router as public load balancer provider
click on the newly created VPC -> click on the VPC tier -> click internal LB
Add internal LB,
Logoff domain-admin and login as root admin
Navigate the VPC created previously and click internal LB, internal lb is not showing up.
Same steps for Public LB IP addresses except select the correct Network offering while creating a tier.
Expected Behaviour:
================
Root admin should be able to manage VPC created by Domain admin user .
Actual Behaviour:
==============
Root admin cannot see VPC created by Domain admin user and hence not able to manage it.
Fix:
===
Added the parameter listAll=true in case of Internal LB as well as Public LB IP addresses.
* pr/1301:
CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1b5c6457
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1b5c6457
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1b5c6457
Branch: refs/heads/4.7
Commit: 1b5c64578f393568380e2ef67155a34eb31bff0e
Parents: 5566789 9014cd3
Author: Remi Bergsma <gi...@remi.nl>
Authored: Sat Jan 16 19:40:06 2016 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Sat Jan 16 19:40:07 2016 +0100
----------------------------------------------------------------------
ui/scripts/vpc.js | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/1b5c6457/ui/scripts/vpc.js
----------------------------------------------------------------------