You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:17:22 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12816: ARROW-16025: [Python][C++] Fix segmentation fault when closing ORCFileWritter

jorisvandenbossche commented on code in PR #12816:
URL: https://github.com/apache/arrow/pull/12816#discussion_r845062725


##########
cpp/src/arrow/adapters/orc/adapter_test.cc:
##########
@@ -406,6 +423,10 @@ TEST(TestAdapterRead, ReadIntAndStringFileMultipleStripes) {
 
 // Trivial
 
+class TestORCWriterTrivialNoWrite : public ::testing::Test {};
+TEST_F(TestORCWriterTrivialNoWrite, noWrite) {
+  TestORCWriterNoWrite(kDefaultSmallMemStreamSize / 16);

Review Comment:
   Is there a reason to not just put the test code here instead of going through the helper function? The other tests often use some helper function, but that is maybe always because it is used multiple times?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org