[jira] [Commented] (CALCITE-3324) Infinite loop when calling DDL from remote Avatica driver to LocalService wrapping CalciteMetaImpl

["Robert Yokota (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065916#comment-17065916 ] 

Robert Yokota commented on CALCITE-3324:
----------------------------------------

The corresponding fix in Avatica 1.16.0 has been made.  Can I get a review of the PR [https://github.com/apache/calcite/pull/1441] for Calcite?

> Infinite loop when calling DDL from remote Avatica driver to LocalService wrapping CalciteMetaImpl
> --------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3324
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3324
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica, core
>    Affects Versions: 1.20.0
>            Reporter: Robert Yokota
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: avatica-1.16.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> I encountered an infinite loop when submitting DDL from a remote Avatica driver (using sqlline) against a {{LocalService}} wrapping {{CalciteMetaImpl}}.
> I was able to debug the issue and verified a fix.
> The problem was that in {{CalciteMetaImpl.prepareAndExecute}}, the updateCount is not being passed to the {{MetaResultSet}} constructor.  Instead, the updateCount is always set to -1.  This incorrectly instructs the remote Avatica driver to fetch results when there aren't any, which causes it to loop.
> By fixing the {{CalciteMetaImpl.prepareAndExecute}} method to set the updateCount in {{MetaResultSet}}, I was able to fix the infinite loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)